[PATCH 0/3] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

[PATCH 0/3] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

[Chen Gang]

unicore32 has implemented 'find_first_bit', 'find_first_zero_bit',
'pm_power_off', and '__cpuc_coherent_kern_range', need export them to
avoid compiling failure.

The related error (with allmodconfig under unicore32):

    MODPOST 4039 modules
  ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
  ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
  [...]
  ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
  ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
  [...]

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/kernel/ksyms.c   | 2 ++
 arch/unicore32/kernel/process.c | 1 +
 arch/unicore32/mm/proc-syms.c   | 2 ++
 3 files changed, 5 insertions(+)


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

[PATCH 1/3] arch: unicore32: ksyms: export additional find_first_*() to avoid compiling failure

[Chen Gang]

Some modules need find_first_bit() and find_first_zero_bit(), so export
them.

The related error (with allmodconfig under unicore32):

    MODPOST 4039 modules
  ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
  ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
  ...


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/kernel/ksyms.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
index e78911a..0323528 100644
--- a/arch/unicore32/kernel/ksyms.c
+++ b/arch/unicore32/kernel/ksyms.c
@@ -23,6 +23,8 @@
 
 #include "ksyms.h"
 
+EXPORT_SYMBOL(find_first_bit);
+EXPORT_SYMBOL(find_first_zero_bit);
 EXPORT_SYMBOL(find_next_zero_bit);
 EXPORT_SYMBOL(find_next_bit);
 
-- 
1.9.2.459.g68773ac

回复： [PATCH 1/3] arch: unicore32: ksyms: export additional find_first_*() to avoid compiling failure

[管雪涛]

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> Some modules need find_first_bit() and find_first_zero_bit(), so export
> them.
> 
> The related error (with allmodconfig under unicore32):
> 
>     MODPOST 4039 modules
>   ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
>   ...
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

> ---
>  arch/unicore32/kernel/ksyms.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index e78911a..0323528 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -23,6 +23,8 @@
>  
>  #include "ksyms.h"
>  
> +EXPORT_SYMBOL(find_first_bit);
> +EXPORT_SYMBOL(find_first_zero_bit);
>  EXPORT_SYMBOL(find_next_zero_bit);
>  EXPORT_SYMBOL(find_next_bit);
>  
> -- 
> 1.9.2.459.g68773ac

[PATCH 2/3] arch: unicore32: ksyms: export 'pm_power_off' to avoid compiling failure.

[Chen Gang]

Two driver modules need 'pm_power_off', so export it.

The related error (with allmodconfig under unicore32):

    MODPOST 4039 modules
  ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
  ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c
index 778ebba..b008e99 100644
--- a/arch/unicore32/kernel/process.c
+++ b/arch/unicore32/kernel/process.c
@@ -60,6 +60,7 @@ void machine_halt(void)
  * Function pointers to optional machine specific functions
  */
 void (*pm_power_off)(void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
 
 void machine_power_off(void)
 {
-- 
1.9.2.459.g68773ac

回复： [PATCH 2/3] arch: unicore32: ksyms: export 'pm_power_off' to avoid compiling failure.

[管雪涛]

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> Two driver modules need 'pm_power_off', so export it.
> 
> The related error (with allmodconfig under unicore32):
> 
>     MODPOST 4039 modules
>   ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
>   ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

> ---
>  arch/unicore32/kernel/process.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c
> index 778ebba..b008e99 100644
> --- a/arch/unicore32/kernel/process.c
> +++ b/arch/unicore32/kernel/process.c
> @@ -60,6 +60,7 @@ void machine_halt(void)
>   * Function pointers to optional machine specific functions
>   */
>  void (*pm_power_off)(void) = NULL;
> +EXPORT_SYMBOL(pm_power_off);
>  
>  void machine_power_off(void)
>  {
> -- 
> 1.9.2.459.g68773ac

[PATCH 3/3] arch: unicore32: ksyms: export '__cpuc_coherent_kern_range' to avoid compiling failure

[Chen Gang]

flush_icache_range() is '__cpuc_coherent_kern_range' under unicore32,
and lkdtm.ko needs it. At present, '__cpuc_coherent_kern_range' is
still used by unicore32, so export it to avoid compiling failure.

The related error (with allmodconfig under unicore32):

  ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/mm/proc-syms.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/unicore32/mm/proc-syms.c b/arch/unicore32/mm/proc-syms.c
index f30071e..21c00fc 100644
--- a/arch/unicore32/mm/proc-syms.c
+++ b/arch/unicore32/mm/proc-syms.c
@@ -19,5 +19,7 @@
 EXPORT_SYMBOL(cpu_dcache_clean_area);
 EXPORT_SYMBOL(cpu_set_pte);
 
+EXPORT_SYMBOL(__cpuc_coherent_kern_range);
+
 EXPORT_SYMBOL(__cpuc_dma_flush_range);
 EXPORT_SYMBOL(__cpuc_dma_clean_range);
-- 
1.9.2.459.g68773ac

回复： [PATCH 3/3] arch: unicore32: ksyms: export '__cpuc_coherent_kern_range' to avoid compiling failure

[管雪涛]

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> flush_icache_range() is '__cpuc_coherent_kern_range' under unicore32,
> and lkdtm.ko needs it. At present, '__cpuc_coherent_kern_range' is
> still used by unicore32, so export it to avoid compiling failure.
> 
> The related error (with allmodconfig under unicore32):
> 
>   ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

> ---
>  arch/unicore32/mm/proc-syms.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/unicore32/mm/proc-syms.c b/arch/unicore32/mm/proc-syms.c
> index f30071e..21c00fc 100644
> --- a/arch/unicore32/mm/proc-syms.c
> +++ b/arch/unicore32/mm/proc-syms.c
> @@ -19,5 +19,7 @@
>  EXPORT_SYMBOL(cpu_dcache_clean_area);
>  EXPORT_SYMBOL(cpu_set_pte);
>  
> +EXPORT_SYMBOL(__cpuc_coherent_kern_range);
> +
>  EXPORT_SYMBOL(__cpuc_dma_flush_range);
>  EXPORT_SYMBOL(__cpuc_dma_clean_range);
> -- 
> 1.9.2.459.g68773ac

回复： [PATCH 0/3] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

[管雪涛]

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> unicore32 has implemented 'find_first_bit', 'find_first_zero_bit',
> 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to
> avoid compiling failure.
> 
> The related error (with allmodconfig under unicore32):
> 
>     MODPOST 4039 modules
>   ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
>   [...]
>   ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
>   ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
>   [...]
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Thanks, I'm waiting for these patches.
And then, I can request-pull in this month.

Xuetao

> ---
>  arch/unicore32/kernel/ksyms.c   | 2 ++
>  arch/unicore32/kernel/process.c | 1 +
>  arch/unicore32/mm/proc-syms.c   | 2 ++
>  3 files changed, 5 insertions(+)
> 
> 
> Thanks.
> -- 
> Chen Gang
> 
> Open, share, and attitude like air, water, and life which God blessed

Re: 回复： [PATCH 0/3] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

[Chen Gang]

On 05/27/2014 08:13 AM, 管雪涛 wrote:
> ----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
>> unicore32 has implemented 'find_first_bit', 'find_first_zero_bit',
>> 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to
>> avoid compiling failure.
>>
>> The related error (with allmodconfig under unicore32):
>>
>>     MODPOST 4039 modules
>>   ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
>>   ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
>>   [...]
>>   ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!
>>   ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
>>   [...]
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> 
> Thanks, I'm waiting for these patches.
> And then, I can request-pull in this month.
> 

Thank you for your work. Hope we can finish within this month. And next
month, I shall start another architectures.

But I am still very glad to continue to provide contributions for
unicore32, and as far as I know:

 - allmodconfig under unicore32 finds many warnings which I skipped now.
   (just like allmodconfig under another architectures without '-W')

 - open source unicore32 qemu still need guys to continue.

 - open source unicore32 cross-compiler still need guys to continue.

If I have chance for them, I shall try (at present, I have started
providing contribution to qemu, and just starting for toolchain, and
will start for kvm/xen in 3rd or 4th quater 2014).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed