From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbaE0TRe (ORCPT ); Tue, 27 May 2014 15:17:34 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:56480 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbaE0TRb (ORCPT ); Tue, 27 May 2014 15:17:31 -0400 Message-ID: <5384E4D4.6040101@kernel.dk> Date: Tue, 27 May 2014 13:17:40 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Christoph Hellwig CC: Ming Lei , Linux Kernel Mailing List , stable Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker References: <20140519151824.GA21762@lst.de> <20140520152303.GA20352@lst.de> <20140521053634.GA4764@lst.de> <20140527181305.GA7975@lst.de> <5384DB97.70606@kernel.dk> <20140527185301.GA8466@lst.de> <5384DF5E.3020304@kernel.dk> <20140527191510.GA9274@lst.de> In-Reply-To: <20140527191510.GA9274@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/2014 01:15 PM, Christoph Hellwig wrote: > On Tue, May 27, 2014 at 12:54:22PM -0600, Jens Axboe wrote: >> Space is plenty big again now... The down side is that the splice trick >> wont work, but if we have more than a few requests on the requeue list, >> we're doing it wrong anyway. > > I don't see a problem with the splice. How about this version (untested so > far)? True, I guess it's iterated afterwards anyway, so that's where you just check it. But I think you sent the old one again, not the new variant :-) -- Jens Axboe