From: Randy Dunlap <rdunlap@infradead.org>
To: Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>,
werner <w.landgraf@ru.ru>,
linux-kernel@vger.kernel.org
Cc: "T. Makphaibulchoke" <tmac@hp.com>,
Andreas Gruenbacher <a.gruenbacher@computer.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: 3.15-rc6 build / link failed fs/built-in mb_cache_entry problems
Date: Tue, 27 May 2014 15:51:26 -0700 [thread overview]
Message-ID: <538516EE.40209@infradead.org> (raw)
In-Reply-To: <5385101D.4050504@hp.com>
On 05/27/2014 03:22 PM, Thavatchai Makphaibulchoke wrote:
> On 05/26/2014 11:04 PM, Randy Dunlap wrote:
>> On 05/26/2014 11:17 AM, werner wrote:
>> @tmac: can mbcache.c #include <linux/log2.h> and use ilog2(NR_BG_LOCKS)
>> instead of using __builtin_log2(NR_BG_LOCKS) ?
>> (ref. commit ID 1f3e55fe02d12213f87869768aa2b0bad3ba9a7d)
>>
>
> I don't see any problem with that, unless somebody else has any concern. Please let me know if you'd like me to submit the change.
I'd say yes since some gcc version(s) don't seem to support __builtin_log2().
--
~Randy
next prev parent reply other threads:[~2014-05-27 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 18:17 3.15-rc6 build / link failed fs/built-in mb_cache_entry problems werner
2014-05-27 5:04 ` Randy Dunlap
2014-05-27 22:22 ` Thavatchai Makphaibulchoke
2014-05-27 22:51 ` Randy Dunlap [this message]
[not found] ` <web-87633644@zbackend1.aha.ru>
2014-05-28 21:54 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2014-05-25 10:04 werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538516EE.40209@infradead.org \
--to=rdunlap@infradead.org \
--cc=a.gruenbacher@computer.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thavatchai.makpahibulchoke@hp.com \
--cc=tmac@hp.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=w.landgraf@ru.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).