From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752205AbaE1IwH (ORCPT ); Wed, 28 May 2014 04:52:07 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:53333 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbaE1IwE (ORCPT ); Wed, 28 May 2014 04:52:04 -0400 Message-ID: <5385A3AF.7060302@linaro.org> Date: Wed, 28 May 2014 09:51:59 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Linus Walleij CC: Russell King , Ulf Hansson , "linux-mmc@vger.kernel.org" , Chris Ball , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function. References: <1400849362-7007-1-git-send-email-srinivas.kandagatla@linaro.org> <1400849589-7626-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/14 09:08, Linus Walleij wrote: > On Fri, May 23, 2014 at 2:53 PM, wrote: > >> + if (unlikely(bytes)) { >> + unsigned char buf[4]; > (...) > > Please think twice about this. > http://lwn.net/Articles/70473/ > http://lwn.net/Articles/420019/ > http://lwn.net/Articles/182369/ > Thanks for the warning. You are right. I think having likely/unlikely is not always right here. thanks, srini > Yours, > Linus Walleij >