From: Tomas Henzl <thenzl@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: xjtuwjp@gmail.com, lindar_liu@usish.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference
Date: Wed, 28 May 2014 13:38:14 +0200 [thread overview]
Message-ID: <5385CAA6.7010708@redhat.com> (raw)
In-Reply-To: <20140528112811.GD11953@infradead.org>
On 05/28/2014 01:28 PM, Christoph Hellwig wrote:
> On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found by using a static code analysis program called cppcheck.
> I can't see how dev->lldd_dev would be NULL here.
The analysis program likely can't know that, the reason for this report
it that dev->lldd_dev is tested for not being null several lines below -
http://lxr.free-electrons.com/source/drivers/scsi/pm8001/pm8001_hwi.c#L4447
So the other option is to remove this^ test.
next prev parent reply other threads:[~2014-05-28 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 16:14 [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-28 11:28 ` Christoph Hellwig
2014-05-28 11:38 ` Tomas Henzl [this message]
2014-05-29 23:05 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385CAA6.7010708@redhat.com \
--to=thenzl@redhat.com \
--cc=JBottomley@parallels.com \
--cc=hch@infradead.org \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox