public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Yong Zhang <yong.zhang@windriver.com>, <ralf@linux-mips.org>,
	<huawei.libin@huawei.com>, <linux-mips@linux-mips.org>,
	<linux-kernel@vger.kernel.org>, Xinwei Hu <huxinwei@huawei.com>
Subject: Re: [PATCH V2] MIPS: change type of asid_cache to unsigned long
Date: Thu, 29 May 2014 16:57:07 +0800	[thread overview]
Message-ID: <5386F663.4010401@huawei.com> (raw)
In-Reply-To: <20140528200929.GA30528@drone.musicnaut.iki.fi>

On 2014/5/29 4:09, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, May 27, 2014 at 12:16:30PM +0800, Li Zefan wrote:
>> On 2014/5/21 13:36, Yong Zhang wrote:
>>> asid_cache must be unsigned long otherwise on 64bit system
>>> it will become 0 if the value in get_new_mmu_context()
>>> reaches 0xffffffff and in the end the assumption of
>>> ASID_FIRST_VERSION is not true anymore thus leads to
>>> more dangerous things.
>>
>> We should describe what problem this bug can lead to, which
>> will help people who encounter the same problem and google it.
> 
> Please describe it, then. Even if the patch is already committed,
> googling would probably still find this e-mail thread.
> 

I don't think Ralf has committed it, so we'll send out a fix
with detailed changelog.


  reply	other threads:[~2014-05-29  8:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21  5:36 [PATCH V2] MIPS: change type of asid_cache to unsigned long Yong Zhang
2014-05-27  4:16 ` Li Zefan
2014-05-27  4:34   ` Yong Zhang
2014-05-27  4:56     ` Li Zefan
2014-05-27  4:50   ` Yong Zhang
2014-05-27  5:07     ` Li Zefan
2014-05-27  5:23       ` Yong Zhang
2014-05-27  5:52         ` Li Zefan
2014-05-28 20:09   ` Aaro Koskinen
2014-05-29  8:57     ` Li Zefan [this message]
2014-05-29 10:20       ` Ralf Baechle
2014-05-30  7:08     ` Libin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386F663.4010401@huawei.com \
    --to=lizefan@huawei.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=huawei.libin@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yong.zhang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox