From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] perf probe segfaulting when asked for variable it doesn't find
Date: Thu, 29 May 2014 18:56:03 +0900 [thread overview]
Message-ID: <53870433.8090606@hitachi.com> (raw)
In-Reply-To: <20140528214406.GE2764@kernel.org>
(2014/05/29 6:44), Arnaldo Carvalho de Melo wrote:
> Masami-san,
>
> While trying:
>
> [root@zoo ~]# perf probe 'vfs_getname=getname_flags:65 pathname=result->name:string'
> Failed to find the location of result at this address.
> Perhaps, it has been optimized out.
> Failed to find 'result' in this function.
> Error: Failed to add events. (-2)
> [root@zoo ~]# perf probe 'vfs_getname=getname_flags:65 pathname=result->name:string'
> Added new event:
> Segmentation fault (core dumped)
>
> I got segfaulted while in the past I would get the much nicer:
>
> [root@zoo ~]# perf probe 'vfs_getname=getname_flags:65 pathname=result->name:string'
> Failed to find the location of result at this address.
> Perhaps, it has been optimized out.
> Failed to find 'result' in this function.
> Error: Failed to add events. (-2)
> [root@zoo ~]#
Oops, I got that. Bad SEGV was reproduced here too.
And I've found an error-handling miss in the convert_variable(),
I'll send a patch for fixing it.
Thank you very much for bisecting and finding my fault.
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-05-29 9:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 21:44 [BUG] perf probe segfaulting when asked for variable it doesn't find Arnaldo Carvalho de Melo
2014-05-29 9:56 ` Masami Hiramatsu [this message]
2014-05-29 10:52 ` [PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if " Masami Hiramatsu
2014-05-29 11:03 ` Masami Hiramatsu
2014-05-29 12:19 ` [PATCH -tip ] [BUGFIX] perf/probe: Fix perf probe to find correct variable DIE Masami Hiramatsu
2014-05-29 12:39 ` Masami Hiramatsu
2014-05-29 13:41 ` Jiri Olsa
2014-06-03 18:29 ` Ingo Molnar
2014-05-29 13:56 ` Arnaldo Carvalho de Melo
2014-06-03 20:38 ` Arnaldo Carvalho de Melo
2014-06-04 8:25 ` Masami Hiramatsu
2014-06-04 11:31 ` Jiri Olsa
2014-06-04 12:19 ` Masami Hiramatsu
2014-06-04 12:22 ` Jiri Olsa
2014-06-03 18:56 ` Arnaldo Carvalho de Melo
2014-06-05 8:15 ` [tip:perf/urgent] perf probe: " tip-bot for Masami Hiramatsu
2014-05-30 6:03 ` [PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if asked for variable it doesn't find Namhyung Kim
2014-05-30 6:32 ` Masami Hiramatsu
2014-06-05 8:15 ` [tip:perf/urgent] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53870433.8090606@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox