From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
lugovskoy@dev.rtsoft.ru
Subject: Re: [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw
Date: Thu, 29 May 2014 19:45:47 +0400 [thread overview]
Message-ID: <5387562B.8070809@dev.rtsoft.ru> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1405291139000.1285-100000@iolanthe.rowland.org>
29.05.2014 19:44, Alan Stern пишет:
> On Thu, 29 May 2014, Nikita Yushchenko wrote:
>
>> 29.05.2014 18:42, One Thousand Gnomes пишет:
>>>> I don't know how linux usb subsystem should behave against such
>>>> "half-existing" hardware. Perhaps hanging is not the best idea...
>>>> but maybe it should be fixed elsewhere, e.g. by masking non-wired
>>>> devices in platform PCI setup. Perhaps controlled by some device-tree
>>>> key.
>>>
>>> Does it have a unique svid/sdid set for the platform - if so you could
>>> just blacklist that combination of vid/did/svid/sdid.
>>
>> Unfortunately vid/did/svid/sdid come from ULI 1553 southbridge chip,
>> that is used by other hardware as well. AFAIK it is still being
>> manufactured, and could appear in PCs or laptops.
>
>>> It would help to print the value of fminterval.
>>> And here to print the value obtained by the readl().
>>
>> I've checked these... all values read as 0xffffffff - which does not
>> look correct
>
> You could have the platform setup code read one of those hardware
> registers, such as FMINTERVAL. If it obtains 0xffffffff, don't
> register the OHCI controller as a platform device.
It is not a platform_device, it is PCI device that is found via bus scan.
next prev parent reply other threads:[~2014-05-29 15:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 4:56 [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw Nikita Yushchenko
2014-05-27 15:08 ` Alan Stern
2014-05-28 7:20 ` Nikita Yushchenko
2014-05-28 14:24 ` Alan Stern
2014-05-29 5:34 ` Nikita Yushchenko
2014-05-29 14:32 ` Nikita Yushchenko
2014-05-29 14:42 ` One Thousand Gnomes
2014-05-29 15:33 ` Nikita Yushchenko
2014-05-29 15:35 ` Nikita Yushchenko
2014-05-29 15:44 ` Alan Stern
2014-05-29 15:45 ` Nikita Yushchenko [this message]
2014-05-29 17:16 ` Alan Stern
2014-05-27 16:39 ` Sergei Shtylyov
2014-05-28 7:21 ` Nikita Yushchenko
2014-05-28 11:57 ` Sergei Shtylyov
2014-05-27 23:27 ` Greg Kroah-Hartman
2014-05-28 7:12 ` Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5387562B.8070809@dev.rtsoft.ru \
--to=nyushchenko@dev.rtsoft.ru \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lugovskoy@dev.rtsoft.ru \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).