public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: sbkim73@samsung.com, sameo@linux.intel.com, lee.jones@linaro.org,
	broonie@kernel.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, jonghwa3.lee@samsung.com
Subject: Re: [PATCH 3/4] regulator: s2mps11: Set offset to voltage hexadecimal code of S2MPU02 LDO regulators
Date: Fri, 30 May 2014 08:46:57 +0900	[thread overview]
Message-ID: <5387C6F1.5060702@samsung.com> (raw)
In-Reply-To: <1401353566.25628.11.camel@AMDC1943>

Hi Krzysztof,

On 05/29/2014 05:52 PM, Krzysztof Kozlowski wrote:
> On śro, 2014-05-28 at 20:10 +0900, Chanwoo Choi wrote:
>> From: Jonghwa Lee <jonghwa3.lee@samsung.com>
>>
>> Different with s2mps1x series, s2mpus02's LDO has offset in voltage hexadecimal
>> code, which is used as in selector in regulator subsystem. It means the value of
>> minimum voltage is not start with 0x0, but has certain offset.
>> (as like BUCK regulator in both of s2mps1x and s2mpu02)
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> Does it mean that driver from previous patch (2/4) does not work
> correctly and the git history is not bisectable? If so than this patch
> should be squashed with 2/4.

OK, I will.

Thanks,
Chanwoo Choi


  reply	other threads:[~2014-05-29 23:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28 11:10 [PATCH 0/4] regulator: s2mps11: Add support S2MPU02 PMIC device Chanwoo Choi
2014-05-28 11:10 ` [PATCH 1/4] mfd: sec-core: Add support for S2MPU02 device Chanwoo Choi
2014-05-29  8:50   ` Krzysztof Kozlowski
2014-05-28 11:10 ` [PATCH 2/4] regulator: s2mps11: Add support S2MPU02 regulator device Chanwoo Choi
2014-05-29  8:51   ` Krzysztof Kozlowski
2014-05-29 23:59     ` Chanwoo Choi
2014-05-28 11:10 ` [PATCH 3/4] regulator: s2mps11: Set offset to voltage hexadecimal code of S2MPU02 LDO regulators Chanwoo Choi
2014-05-29  8:52   ` Krzysztof Kozlowski
2014-05-29 23:46     ` Chanwoo Choi [this message]
2014-05-28 11:10 ` [PATCH 4/4] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC Chanwoo Choi
2014-05-29  8:55   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5387C6F1.5060702@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=broonie@kernel.org \
    --cc=jonghwa3.lee@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox