From: Satish Patel <satish.patel@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robherring2@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Landley <rob@landley.net>, Tony Lindgren <tony@atomide.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 3/5] char: ti-usim: Add driver for USIM module on AM43xx
Date: Fri, 30 May 2014 09:38:20 +0530 [thread overview]
Message-ID: <53880434.7080002@ti.com> (raw)
In-Reply-To: <20140529155349.GD32214@kroah.com>
On 5/29/2014 9:23 PM, Greg Kroah-Hartman wrote:
> On Thu, May 29, 2014 at 03:35:37PM +0530, Satish Patel wrote:
>>>> +enum usim_card_mode {
>>>> + USIM_CARD_MODE_ASYNC = 0, /* asynchronous mode */
>>>> + USIM_CARD_MODE_SYNC_TYPE1, /* synchronous mode: Type 1 */
>>>> + USIM_CARD_MODE_SYNC_TYPE2, /* synchronous mode: Type 2 */
>>>> + USIM_CARD_MODE_SYNC_OTHER, /* Any other synchronous type */
>>>> +};
>>>> +struct usim_data {
>>>> + int slot;
>>>> + int rxexplen;
>>>> + int txlen;
>>>> + unsigned char apdu[256];
>>>> +};
>
> You need to use the proper variable types for a structure that is going
> to cross the user/kernel boundry in an ioctl :(
Do you mean to use __u32 instead int ? make use of types defined in
types.h ? if yes, I will make that change :). Thanks for pointing out.
>
next prev parent reply other threads:[~2014-05-30 4:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 8:57 [PATCH v3 0/5] Smart Card(SC) interface, TI USIM & NxP SC phy driver Satish Patel
2014-05-28 8:57 ` [PATCH v3 1/5] sc_phy:SmartCard(SC) PHY interface to SC controller Satish Patel
2014-05-28 18:44 ` Greg KH
2014-05-29 8:56 ` Satish Patel
2014-05-29 15:51 ` Greg KH
2014-05-30 5:05 ` Satish Patel
2014-05-28 18:53 ` Greg KH
2014-05-29 8:34 ` Satish Patel
2014-05-29 13:47 ` Rob Herring
2014-05-29 15:52 ` Greg KH
2014-05-30 3:51 ` Satish Patel
2014-05-28 8:57 ` [PATCH v3 2/5] misc: tda8026: Add NXP TDA8026 PHY driver Satish Patel
2014-05-28 18:44 ` Greg KH
2014-05-29 8:37 ` Satish Patel
2014-05-29 15:52 ` Greg KH
2014-05-28 8:57 ` [PATCH v3 3/5] char: ti-usim: Add driver for USIM module on AM43xx Satish Patel
2014-05-28 17:56 ` Rob Herring
2014-05-29 10:05 ` Satish Patel
2014-05-29 15:53 ` Greg Kroah-Hartman
2014-05-30 4:08 ` Satish Patel [this message]
2014-05-28 8:57 ` [PATCH v3 4/5] ARM: dts: AM43xx: DT entries added for ti-usim Satish Patel
2014-05-28 8:57 ` [PATCH v3 5/5] ARM: dts: AM43xx-epos-evm: DT entries for ti-usim and phy Satish Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53880434.7080002@ti.com \
--to=satish.patel@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox