From: "Zhu, Lejun" <lejun.zhu@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: broonie@kernel.org, sameo@linux.intel.com,
linux-kernel@vger.kernel.org, jacob.jun.pan@linux.intel.com,
bin.yang@intel.com
Subject: Re: [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support
Date: Fri, 30 May 2014 13:01:11 +0800 [thread overview]
Message-ID: <53881097.6060506@linux.intel.com> (raw)
In-Reply-To: <20140529114921.GK1954@lee--X1>
On 5/29/2014 7:49 PM, Lee Jones wrote:
> On Thu, 29 May 2014, Zhu, Lejun wrote:
>
>> This patch provides chip-specific support for Crystal Cove. Crystal
>> Cove is the PMIC in Baytrail-T platform.
(...)
>> +enum crystal_cove_irq {
>> + PWRSRC_IRQ = 0,
>> + THRM_IRQ,
>> + BCU_IRQ,
>> + ADC_IRQ,
>> + CHGR_IRQ,
>> + GPIO_IRQ,
>> + VHDMIOCP_IRQ
>> +};
>
> I can't help thinking that these should be nice clear #defines
>
> #define CRYSTAL_COVE_IRQ_PWSRC 0
> ...
> #define CRYSTAL_COVE_IRQ_VHDMIOCP 6
>
Sure. I'll fix it.
Best Regards
Lejun
next prev parent reply other threads:[~2014-05-30 5:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 7:19 [PATCH v4 0/3] mfd: Intel SoC Power Management IC Zhu, Lejun
2014-05-29 7:19 ` [PATCH v4 1/3] mfd: intel_soc_pmic: Core driver Zhu, Lejun
2014-05-29 11:40 ` Lee Jones
2014-05-30 4:58 ` Zhu, Lejun
2014-05-30 8:08 ` Lee Jones
2014-05-30 9:03 ` Zhu, Lejun
2014-05-30 9:28 ` Lee Jones
2014-05-31 2:27 ` Zhu, Lejun
2014-05-29 7:19 ` [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support Zhu, Lejun
2014-05-29 11:49 ` Lee Jones
2014-05-30 5:01 ` Zhu, Lejun [this message]
2014-05-29 7:19 ` [PATCH v4 3/3] mfd: intel_soc_pmic: Build files Zhu, Lejun
2014-05-29 11:43 ` Lee Jones
2014-05-30 5:00 ` Zhu, Lejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53881097.6060506@linux.intel.com \
--to=lejun.zhu@linux.intel.com \
--cc=bin.yang@intel.com \
--cc=broonie@kernel.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox