Re: [PATCH v3] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

Herbert Xu
2014-06-20T18:42:48Z

On Fri, Jun 06, 2014 at 11:08:58PM -0400, George Spelvin wrote:
> There's no need for the K_table to be made of 64-bit words. For some
> reason, the original authors didn't fully reduce the values modulo the
> CRC32C polynomial, and so had some 33-bit values in there. They can
> all be reduced to 32 bits.
>
> Doing that cuts the table size in half. Since the code depends on both
> pclmulq and crc32, SSE 4.1 is obviously present, so we can use pmovzxdq
> to fetch it in the correct format.
>
> This adds (measured on Ivy Bridge) 1 cycle per main loop iteration
> (CRC of up to 3K bytes), less than 0.2%. The hope is that the reduced
> D-cache footprint will make up the loss in other code.
>
> Two other related fixes:
> * K_table is read-only, so belongs in .rodata, and
> * There's no need for more than 8-byte alignment
>
> Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: George Spelvin <linux@horizon.com>

Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt