From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>,
kernel-janitors@vger.kernel.org, Johan Hovold <jhovold@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/11] USB: kl5kusb105: Remove useless return variables
Date: Sun, 01 Jun 2014 01:24:24 +0400 [thread overview]
Message-ID: <538A4888.1040204@cogentembedded.com> (raw)
In-Reply-To: <CA+MoWDqDqwOSirh+aP72t_t_2KNajmfn8v5ywpAuLsjJssBwxw@mail.gmail.com>
Hello.
On 06/01/2014 01:21 AM, Peter Senna Tschudin wrote:
>>> This patch remove variables that are initialized with a constant,
>>> are never updated, and are only used as parameter of return.
>>> Return the constant instead of using a variable.
>> The patch does more than just that, it also removes commented out code.
> That was my fault. It was fixed on V2:
> http://marc.info/?l=kernel-janitors&m=140155221232137&w=2
Yes, I forgot to look at the follow-ups before replying.
WBR, Sergei
prev parent reply other threads:[~2014-05-31 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 13:14 [PATCH 1/11] USB: kl5kusb105: Remove useless return variables Peter Senna Tschudin
2014-05-31 14:58 ` Johan Hovold
2014-05-31 16:05 ` Peter Senna Tschudin
2014-05-31 21:17 ` Sergei Shtylyov
2014-05-31 21:21 ` Peter Senna Tschudin
2014-05-31 21:24 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538A4888.1040204@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox