From: Lars-Peter Clausen <lars@metafoo.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jonathan Cameron <jic23@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad_sigma_delta.c: Cleaning up uninitialized variables
Date: Sun, 01 Jun 2014 11:15:02 +0200 [thread overview]
Message-ID: <538AEF16.5070904@metafoo.de> (raw)
In-Reply-To: <1401577904-4764-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 06/01/2014 01:11 AM, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called cppcheck.
This looks like a false positive. And if it was not a false positive the
correct fix certainly is not to initialize the variable to some random value
to silence the warning.
- Lars
next prev parent reply other threads:[~2014-06-01 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 23:11 [PATCH] iio: adc: ad_sigma_delta.c: Cleaning up uninitialized variables Rickard Strandqvist
2014-06-01 9:15 ` Lars-Peter Clausen [this message]
2014-06-01 11:51 ` Rickard Strandqvist
2014-06-01 12:03 ` Lars-Peter Clausen
2014-06-01 12:10 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538AEF16.5070904@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox