public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [GIT PULL] extcon next-v2 for v3.16
Date: Tue, 03 Jun 2014 08:53:42 +0900	[thread overview]
Message-ID: <538D0E86.8080902@samsung.com> (raw)
In-Reply-To: <20140602225517.GB7641@kroah.com>

Dear Greg,

On 06/03/2014 07:55 AM, Greg KH wrote:
> On Mon, Jun 02, 2014 at 02:09:16PM +0900, Chanwoo Choi wrote:
>> Dear Greg,
>>
>> This is extcon-next-v2 full request for v3.16. This pull request includes
>> additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16).
>> I add detailed description of this pull request on below. Please pull extcon with following update.
>>
>> Best Regards,
>> Chanwoo Choi
>>
>> The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:
>>
>>   extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16
> 
> I was thinking it was too late for 3.16-rc1, as the merge window is now
> open and I like to have things in my tree a week or so before that
> happens, but I figured this was nice and self-contained so I would take
> it.

Sorry late pull-request. I'll send next pull-request before -rc7 release certainly.

> 
> So I pulled, and built, and then got this:
> 
> ERROR: "regmap_irq_get_virq" [drivers/extcon/extcon-sm5502.ko] undefined!
> ERROR: "regmap_add_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
> ERROR: "regmap_del_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
> 
> which makes me know that you haven't done much build testing of the code
> :(

Sorry about this mistake. As you comment, I'll check much build testing.

> 
> So I can't take this now, sorry, please fix it up and make it ready for
> 3.17.  If you have bugfixes for 3.16, feel free to send them in a
> separate pull request...

OK, I'll fix it and send pull-requesst for 3.17.
Thanks for your comment.

Best Regards,
Chanwoo Choi



  reply	other threads:[~2014-06-02 23:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  5:09 [GIT PULL] extcon next-v2 for v3.16 Chanwoo Choi
2014-06-02 22:55 ` Greg KH
2014-06-02 23:53   ` Chanwoo Choi [this message]
2014-06-03  0:12     ` Greg KH
2014-06-03  0:26       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538D0E86.8080902@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox