[PATCH] staging: comedi: addi_apci_1564: add addi_watchdog dependency

[PATCH] staging: comedi: addi_apci_1564: add addi_watchdog dependency

[Arnd Bergmann]

With commit aed3f9d498b ("staging: comedi: addi_apci_1564:
absorb apci1564_reset()"), the apci 1564 driver has gained
a dependency on the addi watchdog module, which is not reflected
correctly in Kconfig, and that can lead to link errors
when the watchdog is disabled.

This adds an explicit 'select', like it is done in the other
addi apci drivers that need it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 5d56428..a2f6957 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -651,6 +651,7 @@ config COMEDI_ADDI_APCI_1516
 
 config COMEDI_ADDI_APCI_1564
 	tristate "ADDI-DATA APCI_1564 support"
+	select COMEDI_ADDI_WATCHDOG
 	---help---
 	  Enable support for ADDI-DATA APCI_1564 cards
 

Re: [PATCH] staging: comedi: addi_apci_1564: add addi_watchdog dependency

[Ian Abbott]

On 2014-06-03 11:29, Arnd Bergmann wrote:
> With commit aed3f9d498b ("staging: comedi: addi_apci_1564:
> absorb apci1564_reset()"), the apci 1564 driver has gained
> a dependency on the addi watchdog module, which is not reflected
> correctly in Kconfig, and that can lead to link errors
> when the watchdog is disabled.
>
> This adds an explicit 'select', like it is done in the other
> addi apci drivers that need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-