Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables

[Stephen Boyd <sboyd@codeaurora.org>]

On 06/03/14 11:14, Julia Lawall wrote:
> On Tue, 3 Jun 2014, Stephen Boyd wrote:
>
>> On 06/03/14 03:15, Julia Lawall wrote:
>>> Failure to terminate an of_device_id table can lead to confusing
>>> failures depending on where the compiler places the array. Add a
>>> check to make sure these tables are terminated. Thanks to Mitchel
>>> Humpherys for coming up with the pattern initially.
>>>
>>> Cc: Mitchel Humpherys <mitchelh@codeaurora.org>
>>> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
>>> Cc: Gilles Muller <Gilles.Muller@lip6.fr>
>>> Cc: Nicolas Palix <nicolas.palix@imag.fr>
>>> Cc: Grant Likely <grant.likely@linaro.org>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: devicetree@vger.kernel.org
>>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>>> Acked-by: Grant Likely <grant.likely@linaro.org>
>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>>
>>> ---
>>>
>>> v3: Removed unneeded rule bad_of_table.  Placed * in context rule on the 
>>> closing brace; putting it on the field caused all fields to be marked.
>>>
>>
>> These seem like only minor changes. Why was my authorship removed?
> Probably because I don't know how to provide a new vesion of the patch 
> properly.  What should I have done? 

If you use git format-patch it should insert a "From: <original author>"
line at the beginning of the commit text. This ensures that when git am
is used the correct authorship is retained. It looks like you're using
alpine so I suspect you could just paste this information at the
beginning of the message.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation