From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754789AbaFCSTN (ORCPT ); Tue, 3 Jun 2014 14:19:13 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:57324 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbaFCSTL (ORCPT ); Tue, 3 Jun 2014 14:19:11 -0400 Message-ID: <538E119D.8010304@codeaurora.org> Date: Tue, 03 Jun 2014 11:19:09 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Julia Lawall CC: Michal Marek , linux-kernel@vger.kernel.org, Mitchel Humpherys , Gilles Muller , Nicolas Palix , Grant Likely , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables References: <1401213858-31950-1-git-send-email-sboyd@codeaurora.org> <538E09C1.30200@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/14 11:14, Julia Lawall wrote: > On Tue, 3 Jun 2014, Stephen Boyd wrote: > >> On 06/03/14 03:15, Julia Lawall wrote: >>> Failure to terminate an of_device_id table can lead to confusing >>> failures depending on where the compiler places the array. Add a >>> check to make sure these tables are terminated. Thanks to Mitchel >>> Humpherys for coming up with the pattern initially. >>> >>> Cc: Mitchel Humpherys >>> Cc: Julia Lawall >>> Cc: Gilles Muller >>> Cc: Nicolas Palix >>> Cc: Grant Likely >>> Cc: Rob Herring >>> Cc: devicetree@vger.kernel.org >>> Signed-off-by: Stephen Boyd >>> Acked-by: Grant Likely >>> Signed-off-by: Julia Lawall >>> >>> --- >>> >>> v3: Removed unneeded rule bad_of_table. Placed * in context rule on the >>> closing brace; putting it on the field caused all fields to be marked. >>> >> >> These seem like only minor changes. Why was my authorship removed? > Probably because I don't know how to provide a new vesion of the patch > properly. What should I have done? If you use git format-patch it should insert a "From: " line at the beginning of the commit text. This ensures that when git am is used the correct authorship is retained. It looks like you're using alpine so I suspect you could just paste this information at the beginning of the message. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation