From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request
Date: Wed, 04 Jun 2014 08:15:45 -0600 [thread overview]
Message-ID: <538F2A11.4060800@kernel.dk> (raw)
In-Reply-To: <20140604111133.GA7826@infradead.org>
On 2014-06-04 05:11, Christoph Hellwig wrote:
> On Fri, May 30, 2014 at 08:09:51AM -0600, Jens Axboe wrote:
>> I have applied this one, but it irks me a little bit since we have
>> to touch q->flush_rq->stuff from a potential hot path. I haven't
>> thought much about this yet, but it would be a lot better if we
>> could fold in the flush tag somehow.
>
> This one also breaks scsi-mq by changing the first parameter of
> blk_mq_tag_to_rq. With host-wide tags we won't have a hardware context
> easily available when looking for a request by tag.
Alright, I'll revert it to pass in the tags instead.
--
Jens Axboe
next prev parent reply other threads:[~2014-06-04 14:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:07 [patch]blk-mq: blk_mq_tag_to_rq should handle flush request Shaohua Li
2014-05-09 15:00 ` Christoph Hellwig
2014-05-10 4:00 ` Shaohua Li
2014-05-11 17:40 ` Jens Axboe
2014-05-30 14:09 ` Jens Axboe
2014-06-04 11:11 ` Christoph Hellwig
2014-06-04 14:15 ` Jens Axboe [this message]
2014-06-04 14:20 ` Christoph Hellwig
2014-06-04 14:54 ` Jens Axboe
2014-06-04 14:58 ` Christoph Hellwig
2014-06-04 15:02 ` Jens Axboe
2014-06-04 15:05 ` Christoph Hellwig
2014-06-04 15:08 ` Jens Axboe
2014-06-04 15:10 ` Christoph Hellwig
2014-06-04 15:11 ` Jens Axboe
2014-06-04 15:16 ` Christoph Hellwig
2014-06-04 15:19 ` Jens Axboe
2014-06-04 15:22 ` Christoph Hellwig
2014-06-04 15:28 ` Jens Axboe
2014-06-04 15:31 ` Christoph Hellwig
2014-06-04 15:39 ` Jens Axboe
2014-06-04 15:47 ` Jens Axboe
2014-06-04 16:25 ` Jens Axboe
2014-06-05 1:27 ` Shaohua Li
2014-06-05 2:05 ` Jens Axboe
2014-06-05 2:27 ` Shaohua Li
2014-06-05 2:40 ` Jens Axboe
2014-06-04 15:43 ` Ming Lei
2014-06-04 15:48 ` Jens Axboe
2014-06-04 16:00 ` Ming Lei
2014-06-04 16:09 ` Jens Axboe
2014-06-04 16:26 ` Ming Lei
2014-06-04 16:28 ` Jens Axboe
2014-06-04 16:33 ` Christoph Hellwig
2014-06-04 16:36 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F2A11.4060800@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox