From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD6C3376BA; Fri, 6 Feb 2026 11:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770378362; cv=none; b=GPychZivNZcvSiQ9vmrevR9+lgks/yI0XJtCYD9aV0058BbxNStbz46LOf4IjHCNQp0qAgHe7jm3S/i9xXmpmqmVyc2HFCEhGvXZVLYfDFaYfMB4YIfm9mh6UNJLIdykCjn6/c3+PMvC1eWH2ZLu4Sy66vmc228QR4yANbQDvXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770378362; c=relaxed/simple; bh=XT3tvSr7Whaw/wGhA/JRmGY0OYnnLn73hOQlr1eO6WQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o269i/lYzAb7lMLWvYBvJaYejm+hVagYOf7YExv6alAYWL+TsnT2ewx6uSKm2rWC8t9Fz8cWJU6cYImMQrPtKxjcYWISMP9/r3/r399ruBj6g+Rc/2PlxxULed5ojBflNqimcXt9Xu8Nug8FVXQlB2Bt4tAXVXUcDeeEs6Lt4v0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WezqA93r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WezqA93r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DE15C19421; Fri, 6 Feb 2026 11:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770378361; bh=XT3tvSr7Whaw/wGhA/JRmGY0OYnnLn73hOQlr1eO6WQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WezqA93rvVzTGU8jXDMPN8JLufLwqx66hpVWUezvwvv0fRxUfY8lHiQOmnTTMN0tM A1kU4DDF0/Vvwr9vwmJBH2Yp9i7tnP3VXf8XS6ATyIFYwVroEdgP/Zzed84yUGL07f SyegMd3Kg/Q9ePk2keJeh7hlU+AaJi9ONGG+2aOPpgYP7Dtlcw+CxnDOhAf/YlGuSs bWqD2azVr3W/7p+2IvZnHMJZc4Tvua5g6AkklfWZu9LA3mmdg5Rjnhh+kQvRvR2dRy LO9yRg4WBo0bxfcbeVcdh25k5Y+QqAjaeWfa9fT5o15B0aJh5RE1SEP/SYhhUjfmpQ ikfgjfD/5/Ftg== Message-ID: <538fef61-3903-407e-8486-538a28b99e9d@kernel.org> Date: Fri, 6 Feb 2026 12:45:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/8] mm: convert __HAVE_ARCH_TLB_REMOVE_TABLE to CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE config To: Qi Zheng , andreas@gaisler.com, richard.weiyang@gmail.com, will@kernel.org, peterz@infradead.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dev.jain@arm.com, ioworker0@gmail.com, linmag7@gmail.com, akpm@linux-foundation.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Qi Zheng References: <5ebfa3d4b56e63c6906bda5eccaa9f7194d3a86b.1769515122.git.zhengqi.arch@bytedance.com> <1663ae90-3247-4e12-a25a-049fc3281e19@linux.dev> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <1663ae90-3247-4e12-a25a-049fc3281e19@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/6/26 12:13, Qi Zheng wrote: > > > On 2/6/26 7:06 PM, David Hildenbrand (Arm) wrote: >> On 1/27/26 13:13, Qi Zheng wrote: >>> From: Qi Zheng >>> >>> For architectures that define __HAVE_ARCH_TLB_REMOVE_TABLE, the page >>> tables at the pmd/pud level are generally not of struct ptdesc type, and >>> do not have pt_rcu_head member, thus these architectures cannot support >>> PT_RECLAIM. >>> >>> In preparation for enabling PT_RECLAIM on more architectures, convert >>> __HAVE_ARCH_TLB_REMOVE_TABLE to CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE >>> config, >>> so that we can make conditional judgments in Kconfig. >>> >>> Signed-off-by: Qi Zheng >>> --- >>>   arch/powerpc/Kconfig            | 1 + >>>   arch/powerpc/include/asm/tlb.h  | 1 - >>>   arch/sparc/Kconfig              | 1 + >>>   arch/sparc/include/asm/tlb_64.h | 1 - >>>   include/asm-generic/tlb.h       | 2 +- >>>   mm/Kconfig                      | 3 +++ >>>   6 files changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >>> index 9537a61ebae02..b47aa8fd62742 100644 >>> --- a/arch/powerpc/Kconfig >>> +++ b/arch/powerpc/Kconfig >>> @@ -304,6 +304,7 @@ config PPC >>>       select LOCK_MM_AND_FIND_VMA >>>       select MMU_GATHER_PAGE_SIZE >>>       select MMU_GATHER_RCU_TABLE_FREE >>> +    select HAVE_ARCH_TLB_REMOVE_TABLE >>>       select MMU_GATHER_MERGE_VMAS >>>       select MMU_LAZY_TLB_SHOOTDOWN        if PPC_BOOK3S_64 >>>       select MODULES_USE_ELF_RELA >>> diff --git a/arch/powerpc/include/asm/tlb.h b/arch/powerpc/include/ >>> asm/tlb.h >>> index 2058e8d3e0138..1ca7d4c4b90db 100644 >>> --- a/arch/powerpc/include/asm/tlb.h >>> +++ b/arch/powerpc/include/asm/tlb.h >>> @@ -37,7 +37,6 @@ extern void tlb_flush(struct mmu_gather *tlb); >>>    */ >>>   #define tlb_needs_table_invalidate()    radix_enabled() >>> -#define __HAVE_ARCH_TLB_REMOVE_TABLE >>>   /* Get the generic bits... */ >>>   #include >>> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig >>> index a630d373e6453..25fa2908d6152 100644 >>> --- a/arch/sparc/Kconfig >>> +++ b/arch/sparc/Kconfig >>> @@ -74,6 +74,7 @@ config SPARC64 >>>       select HAVE_KRETPROBES >>>       select HAVE_KPROBES >>>       select MMU_GATHER_RCU_TABLE_FREE if SMP >>> +    select HAVE_ARCH_TLB_REMOVE_TABLE if SMP >> >> Why the SMP? At least in tlb_64.h, it was not protected by SMP IIUC. > > Ah, It's just simply aligned with the MMU_GATHER_RCU_TABLE_FREE above. But does that work as expected for !SMP? -- Cheers, David