From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbaFEKcq (ORCPT ); Thu, 5 Jun 2014 06:32:46 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:59774 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbaFEKco (ORCPT ); Thu, 5 Jun 2014 06:32:44 -0400 Message-ID: <53904760.8000808@linaro.org> Date: Thu, 05 Jun 2014 12:33:04 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Ingo Molnar , Peter Zijlstra CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: Move enum CPU_[xxx_]IDLE to private sched.h References: <1401800345-29468-1-git-send-email-daniel.lezcano@linaro.org> <20140604080214.GJ30445@twins.programming.kicks-ass.net> <20140605101709.GA24277@gmail.com> In-Reply-To: <20140605101709.GA24277@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2014 12:17 PM, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > >> On Tue, Jun 03, 2014 at 02:59:05PM +0200, Daniel Lezcano wrote: >>> The different enum CPU_IDLE, CPU_NOT_IDLE, CPU_NEWLY_IDLE and >>> CPU_MAX_IDLE_TYPES are only used in kernel/sched/fair.c and >>> kernel/sched/stats.c. >>> >>> Move their definitions in the private 'sched.h' file located in the >>> same place than the files above. >>> >> >> Thanks! > > > So this patch breaks x86 64-bit and 32-bit defconfigs: > > In file included from > /home/mingo/tip/arch/x86/kernel/asm-offsets.c:9:0: > /home/mingo/tip/include/linux/sched.h:939:24: error: > ‘CPU_MAX_IDLE_TYPES’ undeclared here (not in a function) > unsigned int lb_count[CPU_MAX_IDLE_TYPES]; > ^ > make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > make[1]: *** [prepare0] Error 2 > make: *** [sub-make] Error 2 Gah ! That deserves -10 points to my karma :( I did not enabled CONFIG_SCHEDSTATS. Sorry for the inconvenience. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog