From: Richard Weinberger <richard@nod.at>
To: Honggang Li <enjoymindful@gmail.com>,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove csum_partial_copy_generic_i386 to clean up exception table
Date: Thu, 05 Jun 2014 23:49:49 +0200 [thread overview]
Message-ID: <5390E5FD.5030400@nod.at> (raw)
In-Reply-To: <1401941724-6703-2-git-send-email-enjoymindful@gmail.com>
Am 05.06.2014 06:15, schrieb Honggang Li:
> arch/x86/um/checksum_32.S had been copy & paste from x86. When build
> x86 uml, csum_partial_copy_generic_i386 mess up the exception table.
> In fact, exception table dose not work in uml kernel.
Are you sure that exception tables do not work on UML?
I said, I'm not sure. Can you please find out?
In arch/um/kernel/trap.c:segv() we have the mechanism for it:
else if (!is_user && arch_fixup(ip, regs))
goto out;
The interesting question is, is this by design or was it just copy&pasted from x86
many moons ago? :)
> And csum_partial_copy_generic_i386 never been called. So, delete it.
I like such clean ups. :-)
Thanks,
//richard
next prev parent reply other threads:[~2014-06-05 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <538F275B.7000508@nod.at>
2014-06-05 4:15 ` [PATCH linux-next] remove csum_partial_copy_generic_i386 to clean up exception table Honggang Li
2014-06-05 4:15 ` [PATCH] " Honggang Li
2014-06-05 21:49 ` Richard Weinberger [this message]
2014-06-09 5:45 ` Real Name
2014-06-17 13:45 ` Real Name
2014-06-21 7:28 ` Real Name
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5390E5FD.5030400@nod.at \
--to=richard@nod.at \
--cc=enjoymindful@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox