From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbaFFFyO (ORCPT ); Fri, 6 Jun 2014 01:54:14 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:51371 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbaFFFyN (ORCPT ); Fri, 6 Jun 2014 01:54:13 -0400 Message-ID: <5391570B.1050402@linux.vnet.ibm.com> Date: Fri, 06 Jun 2014 11:22:11 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Shreyas B. Prabhu" CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] powerpc/powernv : Disable subcore for UP configs References: <1401981695-3682-1-git-send-email-shreyas@linux.vnet.ibm.com> <1401981868-4108-1-git-send-email-shreyas@linux.vnet.ibm.com> In-Reply-To: <1401981868-4108-1-git-send-email-shreyas@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14060605-2674-0000-0000-000000437D61 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2014 08:54 PM, Shreyas B. Prabhu wrote: > Build throws following errors when CONFIG_SMP=n > arch/powerpc/platforms/powernv/subcore.c: In function ‘cpu_update_split_mode’: > arch/powerpc/platforms/powernv/subcore.c:274:15: error: ‘setup_max_cpus’ undeclared (first use in this function) > arch/powerpc/platforms/powernv/subcore.c:285:5: error: lvalue required as left operand of assignment > > 'setup_max_cpus' variable is relevant only on SMP, so there is no point > working around it for UP. Furthermore, subcore.c itself is relevant only > on SMP and hence the better solution is to exclude subcore.c for UP builds. > > Signed-off-by: Shreyas B. Prabhu > --- > This patch applies on top of ben/powerpc.git/next branch > > arch/powerpc/platforms/powernv/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/Makefile b/arch/powerpc/platforms/powernv/Makefile > index 4ad0d34..636d206 100644 > --- a/arch/powerpc/platforms/powernv/Makefile > +++ b/arch/powerpc/platforms/powernv/Makefile > @@ -1,9 +1,9 @@ > obj-y += setup.o opal-takeover.o opal-wrappers.o opal.o opal-async.o > obj-y += opal-rtc.o opal-nvram.o opal-lpc.o opal-flash.o > obj-y += rng.o opal-elog.o opal-dump.o opal-sysparam.o opal-sensor.o > -obj-y += opal-msglog.o subcore.o subcore-asm.o > +obj-y += opal-msglog.o subcore-asm.o > subcore-asm.o can also move down here as well ? > -obj-$(CONFIG_SMP) += smp.o > +obj-$(CONFIG_SMP) += smp.o subcore.o