Re: pte_present check on hugetlb_entry fix for 3.15?

Linus Torvalds
2014-06-06T20:28:19Z

On Fri, Jun 6, 2014 at 10:36 AM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
>
> I poked Linus about this
> early today privately (my fault, apologies) and he had some
> questions/comments on the code.

I changed it a bit (made the patch smaller by removing the now stale
"pte_none()" check) and added a comment about the apparent bogosity of
the generic page table walker to the commit message, but it's
basically applied to the current 3.15 git tree.

If some architecture really has a "pte_present()" function that
requires you to check "pte_none()" first, that architecture is
completely broken and would need to be fixed. I don't think that
exists, though.

Linus