From: Chris Metcalf <cmetcalf@tilera.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables
Date: Sat, 7 Jun 2014 21:41:53 -0400 [thread overview]
Message-ID: <5393BF61.5010306@tilera.com> (raw)
In-Reply-To: <1401577213-3673-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 5/31/2014 7:00 PM, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist<rickard_strandqvist@spectrumdigital.se>
> ---
> arch/tile/kernel/unaligned.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks! Taken into the tile tree with some slight modifications (initialize variables to -1 not 0, and remove the resulting dead code in find_regs).
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2014-06-08 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 23:00 [PATCH] arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables Rickard Strandqvist
2014-06-08 1:41 ` Chris Metcalf [this message]
2014-06-08 17:17 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5393BF61.5010306@tilera.com \
--to=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox