* [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs'
@ 2014-06-08 6:58 Chen Gang
2014-06-12 9:52 ` Liqin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-06-08 6:58 UTC (permalink / raw)
To: liqin.linux, lennox.wu; +Cc: linux-kernel@vger.kernel.org
They are useless, so remove them, the related warning (with
allmodconfig under score):
CC arch/score/kernel/process.o
arch/score/kernel/process.c: In function 'copy_thread':
arch/score/kernel/process.c:76:18: warning: unused variable 'regs' [-Wunused-variable]
struct pt_regs *regs = current_pt_regs();
^
arch/score/kernel/process.c:74:22: warning: unused variable 'ti' [-Wunused-variable]
struct thread_info *ti = task_thread_info(p);
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/score/kernel/process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
index a1519ad3..50bf1b0 100644
--- a/arch/score/kernel/process.c
+++ b/arch/score/kernel/process.c
@@ -71,9 +71,7 @@ void flush_thread(void) {}
int copy_thread(unsigned long clone_flags, unsigned long usp,
unsigned long arg, struct task_struct *p)
{
- struct thread_info *ti = task_thread_info(p);
struct pt_regs *childregs = task_pt_regs(p);
- struct pt_regs *regs = current_pt_regs();
p->thread.reg0 = (unsigned long) childregs;
if (unlikely(p->flags & PF_KTHREAD)) {
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs'
2014-06-08 6:58 [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs' Chen Gang
@ 2014-06-12 9:52 ` Liqin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Liqin Chen @ 2014-06-12 9:52 UTC (permalink / raw)
To: Chen Gang; +Cc: Lennox Wu, linux-kernel@vger.kernel.org
It's ok for S+core
Thanks.
Acked-by: Chen Liqin<liqin.linux@gmail.com>
2014-06-08 14:58 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>:
> They are useless, so remove them, the related warning (with
> allmodconfig under score):
>
> CC arch/score/kernel/process.o
> arch/score/kernel/process.c: In function 'copy_thread':
> arch/score/kernel/process.c:76:18: warning: unused variable 'regs' [-Wunused-variable]
> struct pt_regs *regs = current_pt_regs();
> ^
> arch/score/kernel/process.c:74:22: warning: unused variable 'ti' [-Wunused-variable]
> struct thread_info *ti = task_thread_info(p);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/score/kernel/process.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
> index a1519ad3..50bf1b0 100644
> --- a/arch/score/kernel/process.c
> +++ b/arch/score/kernel/process.c
> @@ -71,9 +71,7 @@ void flush_thread(void) {}
> int copy_thread(unsigned long clone_flags, unsigned long usp,
> unsigned long arg, struct task_struct *p)
> {
> - struct thread_info *ti = task_thread_info(p);
> struct pt_regs *childregs = task_pt_regs(p);
> - struct pt_regs *regs = current_pt_regs();
>
> p->thread.reg0 = (unsigned long) childregs;
> if (unlikely(p->flags & PF_KTHREAD)) {
> --
> 1.7.11.7
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-12 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-08 6:58 [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs' Chen Gang
2014-06-12 9:52 ` Liqin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox