Re: [PATCH 4/7] lib/random32.c: Use instead of hand-rolling it

Daniel Borkmann
2014-06-10T15:13:22Z

On 06/08/2014 02:40 PM, George Spelvin wrote:
...
>>> + for (i = 0; i < round_down(bytes, sizeof(u32)); i += sizeof(u32))
>>> + put_unaligned_le32(prandom_u32_state(state), p+i);
>
>> Nit: 'p + i'
>
> I don't really care, but I'm happy without the spaces; I add them
> to show what binds more weakly, and in this case that's the
> argument-separating comma.

If you invent such things, then first send a patch to
Documentation/CodingStyle to change and discuss this.

Otherwise, I urge you to read:

vi Documentation/CodingStyle +206