Re: [PATCH 4/7] lib/random32.c: Use instead of hand-rolling it

Hannes Frederic Sowa
2014-06-08T20:26:45Z

On Sun, Jun 8, 2014, at 5:40, George Spelvin wrote:
> > Seems fine by me, since it's random anyway archs might not care
> > about the *_le32, though this might yield additional work in some
> > cases I presume.
>
> If you think that's okay, sure. I kept it consistent to get byte-for-byte
> identical results.
>
> If variations in that are allowed, that can also
> simplify the trailing storage case:
>
> + if (bytes & 2)
> + put_unaligned_le16((u16)random, p+i);
> + if (bytes & 1)
> + p[i+bytes-1] = (u8)(random >> 16);

Yes, please! Otherwise the code looks much too complicated for what it does.

> > Nit: '(u8) random'
>
> Actually, my style and most of the kerel is to not put
> a space in a cast, since it binds so tighty.
>
> E.g. compare
>
> git grep ')[a-z]' kernel/
> git grep ') [a-z]' kernel/
>
> Notice that the second is alsmost all comments.
> (There are some spaces in kernel/ptrace.v.)
>
> I'd rather leave it without the space unless you feel
> very strongly about it.

IMHO I wouldn't put a whitespace here.

Bye,
Hannes