From: Larry Finger <Larry.Finger@lwfinger.net>
To: Peter Wu <peter@lekensteyn.nl>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192de: hw.c: Cleaning up conjunction always evaluates to false
Date: Sun, 08 Jun 2014 10:45:50 -0500 [thread overview]
Message-ID: <5394852E.1000601@lwfinger.net> (raw)
In-Reply-To: <3239222.FyGtueg2aO@al>
On 06/08/2014 05:43 AM, Peter Wu wrote:
> On Sunday 08 June 2014 12:36:11 Rickard Strandqvist wrote:
>> Then we use MSR_MASK instead, new patch then. But I will wait a day?
>> Or what is long enough to be sure that nobody else have any
>> objections? How is this usually resolved?
>
> Well, Larry is the maintainer, so he will ultimately pick up patches.
> One or two days should give people some time to read and reply.
My role as maintainer is a little different than others. As I have a private
broadband connection with only 1 Mbps upload, it is not practical for me to
operate a git server. I used to have an account at kernel.org, but I lost it
after the break-in there. As I have never met face-to-face with another Linux
developer, I have had no chance to have my credentials signed, so that resource
is unavailable. As a result, I ACK or NACK patches and they are picked up by
John Linville for drivers in the regular wireless tree, and Greg Kroah-Hartman
for the staging drivers.
> As for MSR_MASK, that macro does not exist yet, I was wondering whether
> it's OK to add a new macro? (Larry?)
Yes, that is OK.
>> Sure, I can send a patch for all the files instead. However, earlier
>> received complaints when I sent patches extending over more than one
>> file.
These do really need to be split a little. There must be at least one patch for
the wireless tree, and a second for staging. In fact, I prefer the way they are
with one for each driver.
Larry
next prev parent reply other threads:[~2014-06-08 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 14:30 [PATCH] net: wireless: rtlwifi: rtl8192de: hw.c: Cleaning up conjunction always evaluates to false Rickard Strandqvist
2014-06-07 15:02 ` Peter Wu
2014-06-07 15:24 ` Rickard Strandqvist
2014-06-08 0:01 ` Larry Finger
2014-06-08 1:15 ` Rickard Strandqvist
2014-06-08 9:26 ` Peter Wu
2014-06-08 10:36 ` Rickard Strandqvist
2014-06-08 10:43 ` Peter Wu
2014-06-08 15:45 ` Larry Finger [this message]
[not found] ` <CAFo99gZuPV=v1k90iPkAGVFrzVq-z=-h8UgD5a3VCN=wMDNU3w@mail.gmail.com>
[not found] ` <CAFo99gYCYkONL9dZYeHwuJKQTCgFQTmg1aAGZdFAOT=MNARh7Q@mail.gmail.com>
2014-06-10 21:52 ` Peter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394852E.1000601@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=peter@lekensteyn.nl \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox