From: Daniel Borkmann <dborkman@redhat.com>
To: George Spelvin <linux@horizon.com>
Cc: davem@davemloft.net, hannes@stressinduktion.org,
linux-kernel@vger.kernel.org, shemminger@osdl.org, tytso@mit.edu
Subject: Re: [PATCH 6/7] lib/random32.c: Randomize timeout to the millisecond, not the second
Date: Sun, 08 Jun 2014 22:01:53 +0200 [thread overview]
Message-ID: <5394C131.8010404@redhat.com> (raw)
In-Reply-To: <20140608124212.2653.qmail@ns.horizon.com>
On 06/08/2014 02:42 PM, George Spelvin wrote:
>> Note, when you talk about efficiency here, this is called once every
>> 40+ secs ... ;)
>
> Agreed, in this case the code size saving (avoid a function call) is the
> main benefit. And I prefer to avoid inefficiency on general priinciples,
> if it's not serving some other goal.
Hm, don't think it will make much of a difference.
next prev parent reply other threads:[~2014-06-08 20:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 8:18 [PATCH 0/7] random32: Various minor cleanups George Spelvin
2014-06-07 8:19 ` [PATCH 1/7] lib/random32.c: Mark self-test data as __initconst George Spelvin
2014-06-08 12:06 ` Daniel Borkmann
2014-06-07 8:20 ` [PATCH 2/7] lib/random32.c: Remove excess calls to prandom_u32_state in initialization George Spelvin
2014-06-08 12:11 ` Daniel Borkmann
2014-06-08 12:19 ` George Spelvin
2014-06-07 8:22 ` [PATCH 3/7] lib/random32.c: Replace an #ifdef with a stub prandom_state_selftest() George Spelvin
2014-06-08 12:16 ` Daniel Borkmann
2014-06-08 12:27 ` George Spelvin
2014-06-07 8:25 ` [PATCH 4/7] lib/random32.c: Use <asm/unaligned.h> instead of hand-rolling it George Spelvin
2014-06-08 12:25 ` Daniel Borkmann
2014-06-08 12:40 ` George Spelvin
2014-06-08 20:26 ` Hannes Frederic Sowa
2014-06-10 15:13 ` Daniel Borkmann
2014-06-07 8:28 ` [PATCH 5/7] lib/random32.c: Make prandom_u32_max efficient for powers of 2 George Spelvin
2014-06-08 12:03 ` Daniel Borkmann
2014-06-08 17:34 ` Hannes Frederic Sowa
2014-06-08 20:02 ` Daniel Borkmann
2014-06-09 0:28 ` George Spelvin
2014-06-08 20:48 ` George Spelvin
2014-06-09 10:30 ` Hannes Frederic Sowa
2014-06-07 8:28 ` [PATCH 6/7] lib/random32.c: Randomize timeout to the millisecond, not the second George Spelvin
2014-06-08 10:43 ` Daniel Borkmann
2014-06-08 11:30 ` George Spelvin
2014-06-08 12:28 ` Daniel Borkmann
2014-06-08 12:42 ` George Spelvin
2014-06-08 20:01 ` Daniel Borkmann [this message]
2014-06-07 8:31 ` [PATCH 7/7] lib/random32.c: Remove redundant U suffixes on integers George Spelvin
2014-06-08 10:36 ` Daniel Borkmann
2014-06-08 11:14 ` George Spelvin
2014-06-08 12:05 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394C131.8010404@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=shemminger@osdl.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox