* [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom_up
@ 2014-06-07 6:21 Fabian Frederick
2014-06-09 1:19 ` Tang Chen
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-07 6:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Andrew Morton, Tang Chen
memblock_set_bottom_up is only called by
__init cmdline_parse_movable_node and __init numa_init.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tang Chen <tangchen@cn.fujitsu.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
This is untested.
include/linux/memblock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 8a20a51..4d6dfcf 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -198,7 +198,7 @@ phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align);
/*
* Set the allocation direction to bottom-up or top-down.
*/
-static inline void memblock_set_bottom_up(bool enable)
+static inline void __init memblock_set_bottom_up(bool enable)
{
memblock.bottom_up = enable;
}
@@ -213,7 +213,7 @@ static inline bool memblock_bottom_up(void)
return memblock.bottom_up;
}
#else
-static inline void memblock_set_bottom_up(bool enable) {}
+static inline void __init memblock_set_bottom_up(bool enable) {}
static inline bool memblock_bottom_up(void) { return false; }
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom_up
2014-06-07 6:21 [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom_up Fabian Frederick
@ 2014-06-09 1:19 ` Tang Chen
0 siblings, 0 replies; 2+ messages in thread
From: Tang Chen @ 2014-06-09 1:19 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andrew Morton
Seeing from the code, it is OK.
Reviewed-by: Tang Chen<tangchen@cn.fujitsu.com>
Thanks.
On 06/07/2014 02:21 PM, Fabian Frederick wrote:
> memblock_set_bottom_up is only called by
> __init cmdline_parse_movable_node and __init numa_init.
>
> Cc: Andrew Morton<akpm@linux-foundation.org>
> Cc: Tang Chen<tangchen@cn.fujitsu.com>
> Signed-off-by: Fabian Frederick<fabf@skynet.be>
> ---
> This is untested.
>
> include/linux/memblock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 8a20a51..4d6dfcf 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -198,7 +198,7 @@ phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align);
> /*
> * Set the allocation direction to bottom-up or top-down.
> */
> -static inline void memblock_set_bottom_up(bool enable)
> +static inline void __init memblock_set_bottom_up(bool enable)
> {
> memblock.bottom_up = enable;
> }
> @@ -213,7 +213,7 @@ static inline bool memblock_bottom_up(void)
> return memblock.bottom_up;
> }
> #else
> -static inline void memblock_set_bottom_up(bool enable) {}
> +static inline void __init memblock_set_bottom_up(bool enable) {}
> static inline bool memblock_bottom_up(void) { return false; }
> #endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-09 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-07 6:21 [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom_up Fabian Frederick
2014-06-09 1:19 ` Tang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox