[PATCH] block: blk-exec.c: Cleaning up local variable address returnd

[PATCH] block: blk-exec.c: Cleaning up local variable address returnd

[Rickard Strandqvist]

Address of local variable assigned to a function parameter

This was partly found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 block/blk-exec.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/block/blk-exec.c b/block/blk-exec.c
index dbf4502..f4d27b1 100644
--- a/block/blk-exec.c
+++ b/block/blk-exec.c
@@ -132,6 +132,11 @@ int blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
 	if (rq->errors)
 		err = -EIO;
 
+	if (rq->sense == sense)	{
+		rq->sense = NULL;
+		rq->sense_len = 0;
+	}
+
 	return err;
 }
 EXPORT_SYMBOL(blk_execute_rq);
-- 
1.7.10.4

Re: [PATCH] block: blk-exec.c: Cleaning up local variable address returnd

[Jens Axboe]

On 2014-06-06 16:37, Rickard Strandqvist wrote:
> Address of local variable assigned to a function parameter
>
> This was partly found using a static code analysis program called cppcheck.

I'd be surprised if this was a real bug, but I agree on principle, we 
should not leak stack data. The code is in place since for drivers that 
rely on sense always being available. I will apply, thanks.

-- 
Jens Axboe