From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: add timer in blk_mq_start_request
Date: Mon, 09 Jun 2014 10:19:48 -0600 [thread overview]
Message-ID: <5395DEA4.90000@kernel.dk> (raw)
In-Reply-To: <1402330601-12837-1-git-send-email-tom.leiming@gmail.com>
On 06/09/2014 10:16 AM, Ming Lei wrote:
> This way will become consistent with non-mq case, also
> avoid to update rq->deadline twice for mq.
>
> The comment said: "We do this early, to ensure we are on
> the right CPU.", but no percpu stuff is used in blk_add_timer(),
> so it isn't necessary. Even when inserting from plug list, there
> is no such guarantee at all.
Thanks, this is a good cleanup. That particular comment predates the
strict mappings of the queues, so it doesn't apply anymore anyway.
--
Jens Axboe
prev parent reply other threads:[~2014-06-09 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 16:16 [PATCH] blk-mq: add timer in blk_mq_start_request Ming Lei
2014-06-09 16:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395DEA4.90000@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox