* [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check
@ 2014-06-09 21:00 Stratos Karafotis
2014-06-10 5:21 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Stratos Karafotis @ 2014-06-09 21:00 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Dirk Brandewie
Cc: linux-pm@vger.kernel.org, LKML
We check the CPU ID during driver init. There is no need
to do it again per logical CPU initialization.
So, remove the duplicate check.
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
---
drivers/cpufreq/intel_pstate.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index aebd457..4e7f492 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
static int intel_pstate_init_cpu(unsigned int cpunum)
{
-
- const struct x86_cpu_id *id;
struct cpudata *cpu;
- id = x86_match_cpu(intel_pstate_cpu_ids);
- if (!id)
- return -ENODEV;
-
all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
if (!all_cpu_data[cpunum])
return -ENOMEM;
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check
2014-06-09 21:00 [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check Stratos Karafotis
@ 2014-06-10 5:21 ` Viresh Kumar
2014-06-10 17:14 ` Dirk Brandewie
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2014-06-10 5:21 UTC (permalink / raw)
To: Stratos Karafotis
Cc: Rafael J. Wysocki, Dirk Brandewie, linux-pm@vger.kernel.org, LKML
On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> We check the CPU ID during driver init. There is no need
> to do it again per logical CPU initialization.
>
> So, remove the duplicate check.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> drivers/cpufreq/intel_pstate.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index aebd457..4e7f492 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
>
> static int intel_pstate_init_cpu(unsigned int cpunum)
> {
> -
> - const struct x86_cpu_id *id;
> struct cpudata *cpu;
>
> - id = x86_match_cpu(intel_pstate_cpu_ids);
> - if (!id)
> - return -ENODEV;
> -
> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
> if (!all_cpu_data[cpunum])
> return -ENOMEM;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check
2014-06-10 5:21 ` Viresh Kumar
@ 2014-06-10 17:14 ` Dirk Brandewie
2014-06-11 0:32 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Dirk Brandewie @ 2014-06-10 17:14 UTC (permalink / raw)
To: Viresh Kumar, Stratos Karafotis
Cc: dirk.j.brandewie, Rafael J. Wysocki, linux-pm@vger.kernel.org,
LKML
On 06/09/2014 10:21 PM, Viresh Kumar wrote:
> On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote:
>> We check the CPU ID during driver init. There is no need
>> to do it again per logical CPU initialization.
>>
>> So, remove the duplicate check.
>>
>> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
>> ---
>> drivers/cpufreq/intel_pstate.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
>> index aebd457..4e7f492 100644
>> --- a/drivers/cpufreq/intel_pstate.c
>> +++ b/drivers/cpufreq/intel_pstate.c
>> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
>>
>> static int intel_pstate_init_cpu(unsigned int cpunum)
>> {
>> -
>> - const struct x86_cpu_id *id;
>> struct cpudata *cpu;
>>
>> - id = x86_match_cpu(intel_pstate_cpu_ids);
>> - if (!id)
>> - return -ENODEV;
>> -
>> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
>> if (!all_cpu_data[cpunum])
>> return -ENOMEM;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check
2014-06-10 17:14 ` Dirk Brandewie
@ 2014-06-11 0:32 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-06-11 0:32 UTC (permalink / raw)
To: Stratos Karafotis
Cc: Dirk Brandewie, Viresh Kumar, dirk.j.brandewie,
linux-pm@vger.kernel.org, LKML
On Tuesday, June 10, 2014 10:14:29 AM Dirk Brandewie wrote:
> On 06/09/2014 10:21 PM, Viresh Kumar wrote:
> > On 10 June 2014 02:30, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> >> We check the CPU ID during driver init. There is no need
> >> to do it again per logical CPU initialization.
> >>
> >> So, remove the duplicate check.
> >>
> >> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> >> ---
> >> drivers/cpufreq/intel_pstate.c | 6 ------
> >> 1 file changed, 6 deletions(-)
> >>
> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> >> index aebd457..4e7f492 100644
> >> --- a/drivers/cpufreq/intel_pstate.c
> >> +++ b/drivers/cpufreq/intel_pstate.c
> >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> >>
> >> static int intel_pstate_init_cpu(unsigned int cpunum)
> >> {
> >> -
> >> - const struct x86_cpu_id *id;
> >> struct cpudata *cpu;
> >>
> >> - id = x86_match_cpu(intel_pstate_cpu_ids);
> >> - if (!id)
> >> - return -ENODEV;
> >> -
> >> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
> >> if (!all_cpu_data[cpunum])
> >> return -ENOMEM;
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
[1/7] applied, please wait with the rest until after 3.16-rc1 is released.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-11 0:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 21:00 [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check Stratos Karafotis
2014-06-10 5:21 ` Viresh Kumar
2014-06-10 17:14 ` Dirk Brandewie
2014-06-11 0:32 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox