* [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local
@ 2014-06-09 21:01 Stratos Karafotis
2014-06-09 21:07 ` David Rientjes
2014-06-10 17:19 ` Dirk Brandewie
0 siblings, 2 replies; 4+ messages in thread
From: Stratos Karafotis @ 2014-06-09 21:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Dirk Brandewie
Cc: linux-pm@vger.kernel.org, LKML
Since we never remove sysfs entry, we can make the intel_pstate_kobject
local.
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index fa44f0f..9533fff 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
static struct attribute_group intel_pstate_attr_group = {
.attrs = intel_pstate_attributes,
};
-static struct kobject *intel_pstate_kobject;
static void intel_pstate_sysfs_expose_params(void)
{
+ struct kobject *intel_pstate_kobject;
int rc;
intel_pstate_kobject = kobject_create_and_add("intel_pstate",
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local
2014-06-09 21:01 [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local Stratos Karafotis
@ 2014-06-09 21:07 ` David Rientjes
2014-06-09 21:24 ` Stratos Karafotis
2014-06-10 17:19 ` Dirk Brandewie
1 sibling, 1 reply; 4+ messages in thread
From: David Rientjes @ 2014-06-09 21:07 UTC (permalink / raw)
To: Stratos Karafotis
Cc: Rafael J. Wysocki, Viresh Kumar, Dirk Brandewie,
linux-pm@vger.kernel.org, LKML
On Tue, 10 Jun 2014, Stratos Karafotis wrote:
> Since we never remove sysfs entry, we can make the intel_pstate_kobject
> local.
>
For even more savings, this function and
intel_pstate_debug_expose_params() can be annotated with __init and freed
after bootstrap.
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index fa44f0f..9533fff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
> static struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };
> -static struct kobject *intel_pstate_kobject;
>
> static void intel_pstate_sysfs_expose_params(void)
> {
> + struct kobject *intel_pstate_kobject;
> int rc;
>
> intel_pstate_kobject = kobject_create_and_add("intel_pstate",
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local
2014-06-09 21:07 ` David Rientjes
@ 2014-06-09 21:24 ` Stratos Karafotis
0 siblings, 0 replies; 4+ messages in thread
From: Stratos Karafotis @ 2014-06-09 21:24 UTC (permalink / raw)
To: David Rientjes
Cc: Rafael J. Wysocki, Viresh Kumar, Dirk Brandewie,
linux-pm@vger.kernel.org, LKML
On 10/06/2014 12:07 πμ, David Rientjes wrote:
> On Tue, 10 Jun 2014, Stratos Karafotis wrote:
>
>> Since we never remove sysfs entry, we can make the intel_pstate_kobject
>> local.
>>
>
> For even more savings, this function and
> intel_pstate_debug_expose_params() can be annotated with __init and freed
> after bootstrap.
Thanks for your comment, David!
I will do this in v2.
Stratos
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local
2014-06-09 21:01 [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local Stratos Karafotis
2014-06-09 21:07 ` David Rientjes
@ 2014-06-10 17:19 ` Dirk Brandewie
1 sibling, 0 replies; 4+ messages in thread
From: Dirk Brandewie @ 2014-06-10 17:19 UTC (permalink / raw)
To: Stratos Karafotis, Rafael J. Wysocki, Viresh Kumar,
Dirk Brandewie
Cc: dirk.brandewie, linux-pm@vger.kernel.org, LKML
On 06/09/2014 02:01 PM, Stratos Karafotis wrote:
> Since we never remove sysfs entry, we can make the intel_pstate_kobject
> local.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index fa44f0f..9533fff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
> static struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };
> -static struct kobject *intel_pstate_kobject;
>
> static void intel_pstate_sysfs_expose_params(void)
> {
> + struct kobject *intel_pstate_kobject;
> int rc;
>
> intel_pstate_kobject = kobject_create_and_add("intel_pstate",
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-10 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 21:01 [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local Stratos Karafotis
2014-06-09 21:07 ` David Rientjes
2014-06-09 21:24 ` Stratos Karafotis
2014-06-10 17:19 ` Dirk Brandewie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox