[PATCH] genksyms: Include scripts/Makefile.lib

[PATCH] genksyms: Include scripts/Makefile.lib

[Guido Günther]

Otherwise when building out of tree like

make V=1 O=/var/scratch/kernel/

it fails like

make -f /home/agx/linux/scripts/Makefile.build obj=scripts
make -f /home/agx/linux/scripts/Makefile.build obj=scripts/genksyms
(cat /dev/null; ) > scripts/genksyms/modules.order
  gcc -Wp,-MD,scripts/genksyms/.lex.lex.o.d -Iscripts/genksyms -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer  -I/home/agx/linux/scripts/genksyms -Iscripts/genksyms -c -o scripts/genksyms/lex.lex.o scripts/genksyms/lex.lex.c
scripts/genksyms/lex.lex.c_shipped:567:23: fatal error: parse.tab.h: No such file or directory
compilation terminated.
scripts/Makefile.host:134: recipe for target 'scripts/genksyms/lex.lex.o' failed
make[3]: *** [scripts/genksyms/lex.lex.o] Error 1
/home/agx/linux/scripts/Makefile.build:465: recipe for target 'scripts/genksyms' failed
make[2]: *** [scripts/genksyms] Error 2
/home/agx/linux/Makefile:542: recipe for target 'scripts' failed

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---

I'm not sure wether this is the root cause and would be happy any
input on where to dig. GNU make is version 4.0.

 scripts/genksyms/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
index aca33b9..1d86d14 100644
--- a/scripts/genksyms/Makefile
+++ b/scripts/genksyms/Makefile
@@ -1,3 +1,4 @@
+include scripts/Makefile.lib
 
 hostprogs-y	:= genksyms
 always		:= $(hostprogs-y)
-- 
2.0.0.rc0

Re: [PATCH] genksyms: Include scripts/Makefile.lib

[Michal Marek]

Dne 23.5.2014 15:15, Guido Günther napsal(a):
> Otherwise when building out of tree like
> 
> make V=1 O=/var/scratch/kernel/
> 
> it fails like
> 
> make -f /home/agx/linux/scripts/Makefile.build obj=scripts
> make -f /home/agx/linux/scripts/Makefile.build obj=scripts/genksyms
> (cat /dev/null; ) > scripts/genksyms/modules.order
>   gcc -Wp,-MD,scripts/genksyms/.lex.lex.o.d -Iscripts/genksyms -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer  -I/home/agx/linux/scripts/genksyms -Iscripts/genksyms -c -o scripts/genksyms/lex.lex.o scripts/genksyms/lex.lex.c
> scripts/genksyms/lex.lex.c_shipped:567:23: fatal error: parse.tab.h: No such file or directory
> compilation terminated.
> scripts/Makefile.host:134: recipe for target 'scripts/genksyms/lex.lex.o' failed
> make[3]: *** [scripts/genksyms/lex.lex.o] Error 1
> /home/agx/linux/scripts/Makefile.build:465: recipe for target 'scripts/genksyms' failed
> make[2]: *** [scripts/genksyms] Error 2
> /home/agx/linux/Makefile:542: recipe for target 'scripts' failed
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> 
> I'm not sure wether this is the root cause and would be happy any
> input on where to dig. GNU make is version 4.0.
> 
>  scripts/genksyms/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
> index aca33b9..1d86d14 100644
> --- a/scripts/genksyms/Makefile
> +++ b/scripts/genksyms/Makefile
> @@ -1,3 +1,4 @@
> +include scripts/Makefile.lib
>  
>  hostprogs-y	:= genksyms
>  always		:= $(hostprogs-y)

scripts/Makefile.lib is included by the Makefile that includes
scripts/genksyms/Makefile. So this is certainly not the right fix. With
which kernel version are you seeing this and what are the exact steps to
reproduce? Also please attach the full log leading to the failure.
Needless to say, I can't reproduce it.

Thanks,
Michal

Re: [PATCH] genksyms: Include scripts/Makefile.lib

[Guido Günther]

On Mon, Jun 09, 2014 at 11:21:15PM +0200, Michal Marek wrote:
> Dne 23.5.2014 15:15, Guido Günther napsal(a):
> > Otherwise when building out of tree like
> > 
> > make V=1 O=/var/scratch/kernel/
> > 
> > it fails like
> > 
> > make -f /home/agx/linux/scripts/Makefile.build obj=scripts
> > make -f /home/agx/linux/scripts/Makefile.build obj=scripts/genksyms
> > (cat /dev/null; ) > scripts/genksyms/modules.order
> >   gcc -Wp,-MD,scripts/genksyms/.lex.lex.o.d -Iscripts/genksyms -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer  -I/home/agx/linux/scripts/genksyms -Iscripts/genksyms -c -o scripts/genksyms/lex.lex.o scripts/genksyms/lex.lex.c
> > scripts/genksyms/lex.lex.c_shipped:567:23: fatal error: parse.tab.h: No such file or directory
> > compilation terminated.
> > scripts/Makefile.host:134: recipe for target 'scripts/genksyms/lex.lex.o' failed
> > make[3]: *** [scripts/genksyms/lex.lex.o] Error 1
> > /home/agx/linux/scripts/Makefile.build:465: recipe for target 'scripts/genksyms' failed
> > make[2]: *** [scripts/genksyms] Error 2
> > /home/agx/linux/Makefile:542: recipe for target 'scripts' failed
> > 
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > ---
> > 
> > I'm not sure wether this is the root cause and would be happy any
> > input on where to dig. GNU make is version 4.0.
> > 
> >  scripts/genksyms/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
> > index aca33b9..1d86d14 100644
> > --- a/scripts/genksyms/Makefile
> > +++ b/scripts/genksyms/Makefile
> > @@ -1,3 +1,4 @@
> > +include scripts/Makefile.lib
> >  
> >  hostprogs-y	:= genksyms
> >  always		:= $(hostprogs-y)
> 
> scripts/Makefile.lib is included by the Makefile that includes
> scripts/genksyms/Makefile. So this is certainly not the right fix. With
> which kernel version are you seeing this and what are the exact steps to
> reproduce? Also please attach the full log leading to the failure.
> Needless to say, I can't reproduce it.

Hmm....this was v3.15-rc6 but I can't reproduce this either with a
current Debian sid. In case this pops up again I'll send the full log.
Thanks,
 -- Guido