From: Chanwoo Choi <cw00.choi@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, grant.likely@linaro.org, robh+dt@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: of: Add support for parsing regulator_state for suspend state
Date: Tue, 10 Jun 2014 08:59:01 +0900 [thread overview]
Message-ID: <53964A45.3010108@samsung.com> (raw)
In-Reply-To: <20140609192133.GD5099@sirena.org.uk>
Hi Mark,
On 06/10/2014 04:21 AM, Mark Brown wrote:
> On Mon, Jun 09, 2014 at 07:29:39PM +0900, Chanwoo Choi wrote:
>
>> + ret = of_property_read_u32(suspend_np, "regulator-mode", &pval);
>> + if (!ret)
>> + suspend_state->mode = pval;
>
> If we're going to do that we'd need to define what modes mean in the DT
> binding - currently there's no support for modes at all because it's
> complicated to come up with sensible and meaningful generic defintions.
>
The 'regulator-mode' of this patch means following defined constant variable
as following in include/linux/regulator/consumer.h:
#define REGULATOR_MODE_FAST 0x1
#define REGULATOR_MODE_NORMAL 0x2
#define REGULATOR_MODE_IDLE 0x4
#define REGULATOR_MODE_STANDBY 0x8
If regulator consumer would use this mode('regulator-mode),
specific regulator driver should implement rdev->desc->ops->set_suspend_mode function
to control regulator state according to 'regulator-mode' in suspend state.
Best Regards,
Chanwoo CHoi
next prev parent reply other threads:[~2014-06-09 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 10:29 [PATCH 0/2] regulator: of: Add support for pasing regulator suspend state Chanwoo Choi
2014-06-09 10:29 ` [PATCH 1/2] regulator: of: Add support for parsing regulator_state for " Chanwoo Choi
2014-06-09 19:21 ` Mark Brown
2014-06-09 23:59 ` Chanwoo Choi [this message]
2014-06-10 10:02 ` Mark Brown
2014-06-10 10:25 ` Chanwoo Choi
2014-06-09 10:29 ` [PATCH 2/2] dt-bindings: regulator: Add regulator suspend state for PM state Chanwoo Choi
2014-06-09 19:16 ` Mark Brown
2014-06-10 1:30 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53964A45.3010108@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox