From: Chanwoo Choi <cw00.choi@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, sbkim73@samsung.com, sameo@linux.intel.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
jonghwa3.lee@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCHv3 2/3] regulator: s2mps11: Add support S2MPU02 regulator device
Date: Tue, 10 Jun 2014 10:32:16 +0900 [thread overview]
Message-ID: <53966020.9020600@samsung.com> (raw)
In-Reply-To: <20140609195543.GK5099@sirena.org.uk>
Hi Mark,
On 06/10/2014 04:55 AM, Mark Brown wrote:
> On Mon, Jun 09, 2014 at 03:15:47PM +0900, Chanwoo Choi wrote:
>> This patch add S2MPU02 regulator device to existing S2MPS11 device driver
>> because of little difference between S2MPS1x and S2MPU02. The S2MPU02
>> regulator device includes LDO[1-28] and BUCK[1-7].
>
> Acked-by: Mark Brown <broonie@linaro.org>
>
> but a few nits:
>
>> + case S2MPS14X:
>> + switch (rdev_id) {
>> + case S2MPS14_LDO3:
>> + return 0;
>> + };
>
> Extra ; here, and a missing default case here and in the rest of the
> switches. The default cases have no effect but are better style.
>
OK, I'll add 'default' case statement.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2014-06-10 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 6:15 [PATCHv3 0/3] mfd: sec-core: Add support S2MPU02 PMIC device Chanwoo Choi
2014-06-09 6:15 ` [PATCHv3 1/3] mfd: sec-core: Add support for S2MPU02 device Chanwoo Choi
2014-06-09 6:15 ` [PATCHv3 2/3] regulator: s2mps11: Add support S2MPU02 regulator device Chanwoo Choi
2014-06-09 19:55 ` Mark Brown
2014-06-10 1:32 ` Chanwoo Choi [this message]
2014-06-09 6:15 ` [PATCHv3 3/3] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53966020.9020600@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@kernel.org \
--cc=jonghwa3.lee@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox