From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Paul Carpenter <paul@pcserviceselectronics.co.uk>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Hans de Goede <hdegoede@redhat.com>,
Shuge <shuge@allwinnertech.com>,
kevin@allwinnertech.com, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [RESEND2 PATCH v4 2/2] i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) controller support
Date: Tue, 10 Jun 2014 15:49:41 +0200 [thread overview]
Message-ID: <53970CF5.50701@free-electrons.com> (raw)
In-Reply-To: <5396C848.8020701@pcserviceselectronics.co.uk>
Hello Paul,
On 10/06/2014 10:56, Paul Carpenter wrote:
> Wolfram Sang wrote:
>> On Tue, Jun 03, 2014 at 10:49:52AM +0200, Boris BREZILLON wrote:
>>> The P2WI looks like an SMBus controller which only supports byte data
>>> transfers. But, it differs from standard SMBus protocol on several
>>> aspects:
>>> - it supports only one slave device, and thus drop the address field
>>> - it adds a parity bit every 8bits of data
>>> - only one read access is required to read a byte (instead of a read
>>> followed by a write access in standard SMBus protocol)
>
> Minor quibble should be
> "(instead of a write followed by a read access in standard SMBus
> protocol)"
>
Fixed.
Thanks for pointing this out.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2014-06-10 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 8:49 [RESEND2 PATCH v4 0/2] i2c: sunxi: add P2WI controller support Boris BREZILLON
2014-06-03 8:49 ` [RESEND2 PATCH v4 1/2] i2c: sunxi: add P2WI DT bindings documentation Boris BREZILLON
2014-06-03 8:49 ` [RESEND2 PATCH v4 2/2] i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) controller support Boris BREZILLON
2014-06-10 8:38 ` Wolfram Sang
2014-06-10 8:54 ` Boris BREZILLON
2014-06-10 9:10 ` Boris BREZILLON
2014-06-10 8:56 ` Paul Carpenter
2014-06-10 13:49 ` Boris BREZILLON [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53970CF5.50701@free-electrons.com \
--to=boris.brezillon@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kevin@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=paul@pcserviceselectronics.co.uk \
--cc=rdunlap@infradead.org \
--cc=shuge@allwinnertech.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox