public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: qcom: select GSBI from mach kconfig
@ 2014-06-10 11:16 Srinivas Kandagatla
  2014-06-10 17:31 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Kandagatla @ 2014-06-10 11:16 UTC (permalink / raw)
  To: Kumar Gala, linux-arm-msm
  Cc: linux-kernel, linux-arm-kernel, Russell King, David Brown,
	Srinivas Kandagatla

This patch adds GSBI selection automatically from mach kconfig, As GSBI
seems to be the very basic SOC specific driver and serial driver depends on it.
I think this option should be selected via mach kconfig rather than adding
it to any defconfig.

Without this patch multi_v7_defconfig can not show up console on
IFC6410.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm/mach-qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
index 5bac591..d68d7ee 100644
--- a/arch/arm/mach-qcom/Kconfig
+++ b/arch/arm/mach-qcom/Kconfig
@@ -7,6 +7,7 @@ config ARCH_QCOM
 	select GENERIC_CLOCKEVENTS
 	select HAVE_SMP
 	select QCOM_SCM if SMP
+	select QCOM_GSBI
 	help
 	  Support for Qualcomm's devicetree based systems.
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: qcom: select GSBI from mach kconfig
  2014-06-10 11:16 [PATCH] ARM: qcom: select GSBI from mach kconfig Srinivas Kandagatla
@ 2014-06-10 17:31 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2014-06-10 17:31 UTC (permalink / raw)
  To: Srinivas Kandagatla
  Cc: Kumar Gala, linux-arm-msm, linux-kernel, linux-arm-kernel,
	Russell King, David Brown

On 06/10/14 04:16, Srinivas Kandagatla wrote:
> This patch adds GSBI selection automatically from mach kconfig, As GSBI
> seems to be the very basic SOC specific driver and serial driver depends on it.
> I think this option should be selected via mach kconfig rather than adding
> it to any defconfig.
>
> Without this patch multi_v7_defconfig can not show up console on
> IFC6410.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>

No, we should be getting rid of selects, not adding more. Just put this
in the multi_v7_defconfig.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-10 17:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 11:16 [PATCH] ARM: qcom: select GSBI from mach kconfig Srinivas Kandagatla
2014-06-10 17:31 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox