public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] BLOCK/ELEVATOR: add __init to elv_register
@ 2014-06-10 18:04 Fabian Frederick
  2014-06-10 19:13 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-10 18:04 UTC (permalink / raw)
  To: linux-kernel; +Cc: Fabian Frederick, Jens Axboe, Andrew Morton

elv_register is only called by elevator init functions:

__init cfq_init
__init deadline_init
__init noop_init

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 block/elevator.c         | 2 +-
 include/linux/elevator.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index 1e01b66..f35eddd 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -845,7 +845,7 @@ void elv_unregister_queue(struct request_queue *q)
 }
 EXPORT_SYMBOL(elv_unregister_queue);
 
-int elv_register(struct elevator_type *e)
+int __init elv_register(struct elevator_type *e)
 {
 	char *def = "";
 
diff --git a/include/linux/elevator.h b/include/linux/elevator.h
index df63bd3..4ff262e 100644
--- a/include/linux/elevator.h
+++ b/include/linux/elevator.h
@@ -144,7 +144,7 @@ extern void elv_drain_elevator(struct request_queue *);
  * io scheduler registration
  */
 extern void __init load_default_elevator_module(void);
-extern int elv_register(struct elevator_type *);
+extern int __init elv_register(struct elevator_type *);
 extern void elv_unregister(struct elevator_type *);
 
 /*
-- 
1.8.4.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] BLOCK/ELEVATOR: add __init to elv_register
  2014-06-10 18:04 [PATCH 1/1] BLOCK/ELEVATOR: add __init to elv_register Fabian Frederick
@ 2014-06-10 19:13 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2014-06-10 19:13 UTC (permalink / raw)
  To: Fabian Frederick, linux-kernel; +Cc: Andrew Morton

On 06/10/2014 12:04 PM, Fabian Frederick wrote:
> elv_register is only called by elevator init functions:
> 
> __init cfq_init
> __init deadline_init
> __init noop_init

Thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-10 19:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 18:04 [PATCH 1/1] BLOCK/ELEVATOR: add __init to elv_register Fabian Frederick
2014-06-10 19:13 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox