From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 4/5] kernfs: introduce kernfs_pin_sb() and kernfs_drop_sb()
Date: Thu, 12 Jun 2014 14:32:28 +0800 [thread overview]
Message-ID: <5399497C.8080402@huawei.com> (raw)
In-Reply-To: <53994943.60703@huawei.com>
kernfs_pin_sb() tries to get a refcnt of the superblock, while
kernfs_drop_sb() drops this refcnt.
This will be used by cgroupfs.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
fs/kernfs/mount.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
include/linux/kernfs.h | 3 +++
2 files changed, 48 insertions(+)
diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index f25a7c0..4f924e0 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
@@ -210,6 +210,51 @@ void kernfs_kill_sb(struct super_block *sb)
kernfs_put(root_kn);
}
+/**
+ * kernfs_pin_sb: try to pin the superblock associated with a kernfs_root
+ * @kernfs_root: the kernfs_root in question
+ * @ns: the namespace tag
+ *
+ * Pin the superblock so the superblock won't be destroyed in subsequent
+ * operations.
+ */
+bool kernfs_pin_sb(struct kernfs_root *root, const void *ns)
+{
+ struct kernfs_super_info *info;
+ int ret = false;
+
+ mutex_lock(&kernfs_mutex);
+ list_for_each_entry(info, &root->supers, node) {
+ if (info->ns == ns) {
+ ret = atomic_inc_not_zero(&info->sb->s_active);
+ break;
+ }
+ }
+ mutex_unlock(&kernfs_mutex);
+ return ret;
+}
+
+/**
+ * kernfs_drop_sb: drop the refcnt that we got by kernfs_pin_sb()
+ * @root: the kernfs_root in question
+ * @ns: the namespace tag
+ *
+ * This must be paired with kernfs_pin_sb(). It will require sb->u_mount
+ * if the refcnt reaches zero.
+ */
+void kernfs_drop_sb(struct kernfs_root *root, const void *ns)
+{
+ struct kernfs_super_info *info;
+
+ mutex_lock(&kernfs_mutex);
+ list_for_each_entry(info, &root->supers, node) {
+ if (info->ns == ns)
+ break;
+ }
+ mutex_unlock(&kernfs_mutex);
+ deactivate_super(info->sb);
+}
+
void __init kernfs_init(void)
{
kernfs_node_cache = kmem_cache_create("kernfs_node_cache",
diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index 589318b..1958017 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -288,6 +288,9 @@ struct dentry *kernfs_mount_ns(struct file_system_type *fs_type, int flags,
const void *ns);
void kernfs_kill_sb(struct super_block *sb);
+bool kernfs_pin_sb(struct kernfs_root *root, const void *ns);
+void kernfs_drop_sb(struct kernfs_root *root, const void *ns);
+
void kernfs_init(void);
#else /* CONFIG_KERNFS */
--
1.8.0.2
next prev parent reply other threads:[~2014-06-12 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 6:31 [PATCH 1/5] cgroup: fix broken css_has_online_children() Li Zefan
2014-06-12 6:31 ` [PATCH 2/5] percpu-ref: introduce percpu_ref_alive() Li Zefan
2014-06-12 6:32 ` [PATCH 3/5] cgroup: fix mount failure in a corner case Li Zefan
2014-06-20 19:10 ` Tejun Heo
2014-06-24 1:15 ` Li Zefan
2014-06-12 6:32 ` Li Zefan [this message]
2014-06-12 6:33 ` [PATCH 5/5] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb() Li Zefan
2014-06-20 19:35 ` Tejun Heo
2014-06-24 1:22 ` Li Zefan
2014-06-24 21:01 ` Tejun Heo
2014-06-25 1:56 ` Li Zefan
2014-06-25 15:00 ` Tejun Heo
2014-06-27 6:32 ` Li Zefan
2014-06-27 15:00 ` Tejun Heo
2014-06-17 19:26 ` [PATCH 1/5] cgroup: fix broken css_has_online_children() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399497C.8080402@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).