Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

Jean Delvare
2014-06-12T10:02:05Z

Le Thursday 12 June 2014 à 11:44 +0200, Guillaume Gardet a écrit :
> Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :
> >
> > On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
> >> Le 12/06/2014 10:36, Sachin Kamat a écrit :
> >>> Hi Guillaume,
> >>>
> >>>
> >>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
> >>> <guillaume.gardet@free.fr> wrote:
> >>>> Hi,
> >>>>
> >>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
> >>>> It fixes the following build error:
> >>>> FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
> >>>>
> >>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
> >>>>
> >>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
> >>> A similar patch has already been submitted by Arnd. Please see below:
> >>> https://lkml.org/lkml/2014/3/15/40
> >> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.
> > It's in mainline kernel already
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf
>
> Ok. It is in mainline but not in 3.15.

And as it stands, it won't be, because stable@vger.kernel.org was not
Cc'd. "Typo" in the subject makes it sound like a trivial and minor
change. "Fix module loading" would probably have made it clearer that it
fixes a real issue.

Guillaume, if this bothers you, please write to stable@vger.kernel.org
and kindly ask them to consider including this commit in future stable
releases.

--
Jean Delvare
SUSE L3 Support