From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
To: Robert Richter <rric@kernel.org>
Cc: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com,
bp@alien8.de, m.chehab@samsung.com, bp@suse.de,
linux-edac@vger.kernel.org, x86@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org
Subject: Re: [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature.
Date: Thu, 12 Jun 2014 15:08:32 +0200 [thread overview]
Message-ID: <5399A650.2020602@linaro.org> (raw)
In-Reply-To: <20140612103238.GB22583@rric.localhost>
On 12.06.2014 12:32, Robert Richter wrote:
> On 28.05.14 09:39:27, Tomasz Nowicki wrote:
>> +config ACPI_APEI_NMI
>> + bool "NMI error notification support"
>> + default y
>> + depends on ACPI_APEI_GHES && X86
>> + help
>> + Firmware first mode can use NMI notification mechanism to report errors
>> + to operating system. This feature is currently supported by X86
>> + architecture only.
>> +
>
> This selection is not necessary. I don't see why one should select
> this at all. It's either there for an arch or not. Just use ARCH_HAS_
> style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no
> need for the ACPI_APEI_GHES dependency then.
>
It does make sense to me, will address your comment appropriately.
Tomasz
next prev parent reply other threads:[~2014-06-12 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 7:39 [PATCH v2 0/5] APEI: Make APEI architecture independent Tomasz Nowicki
2014-05-28 7:39 ` [PATCH v2 1/5] apei, mce: Factor out APEI architecture specific MCE calls Tomasz Nowicki
2014-06-12 10:23 ` Robert Richter
2014-06-12 13:07 ` Tomasz Nowicki
2014-05-28 7:39 ` [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature Tomasz Nowicki
2014-06-12 10:32 ` Robert Richter
2014-06-12 13:08 ` Tomasz Nowicki [this message]
2014-05-28 7:39 ` [PATCH v2 3/5] acpi, apei, ghes: Introduce more generic mechanism to init/deinit GHES error notifications Tomasz Nowicki
2014-05-28 7:39 ` [PATCH v2 4/5] apei, ghes, nmi: Factor out NMI arch-specific calls Tomasz Nowicki
2014-05-28 7:39 ` [PATCH v2 5/5] acpi, apei, ghes: Factor out ioremap virtual memory for IRQ and NMI context Tomasz Nowicki
2014-06-12 8:34 ` [PATCH v2 0/5] APEI: Make APEI architecture independent Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399A650.2020602@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).