From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbaFLTsW (ORCPT ); Thu, 12 Jun 2014 15:48:22 -0400 Received: from casper.infradead.org ([85.118.1.10]:60633 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbaFLTsU (ORCPT ); Thu, 12 Jun 2014 15:48:20 -0400 Message-ID: <539A0400.2080102@infradead.org> Date: Thu, 12 Jun 2014 12:48:16 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Zachary , linux-kernel@vger.kernel.org Subject: Re: Patch Very Minor to loopback.c References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/14 12:43, Zachary wrote: > Very minor patch to loopback.c that I noticed while comparing the > dummy.c code to loopback.c code (dummy.c was based on loopback.c). I > did not see a maintainer in MAINTAINERS in my cursory glance, so I > apologize if this is to the wrong place. I am testing this patch > right now on my laptop and it appears to be working without issues. > It also compiled without warnings. Networking patches should be sent to . Try cc-ing the NETWORKING maintainer. Thanks. > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > index bb96409..f9f88d7 100644 > --- a/drivers/net/loopback.c > +++ b/drivers/net/loopback.c > @@ -22,6 +22,7 @@ > * interface. > * Alexey Kuznetsov: Potential hang under some extreme > * cases removed. > + * Zachary Winnerman: Extremely minor patch in loopback_xmit > * > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License > @@ -72,7 +73,6 @@ static netdev_tx_t loopback_xmit(struct sk_buff *skb, > struct net_device *dev) > { > struct pcpu_lstats *lb_stats; > - int len; > > skb_orphan(skb); > > @@ -86,10 +86,9 @@ static netdev_tx_t loopback_xmit(struct sk_buff *skb, > /* it's OK to use per_cpu_ptr() because BHs are off */ > lb_stats = this_cpu_ptr(dev->lstats); > > - len = skb->len; > if (likely(netif_rx(skb) == NET_RX_SUCCESS)) { > u64_stats_update_begin(&lb_stats->syncp); > - lb_stats->bytes += len; > + lb_stats->bytes += skb->len; > lb_stats->packets++; > u64_stats_update_end(&lb_stats->syncp); > } > -- -- ~Randy