From: David Vrabel <david.vrabel@citrix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: <x86@kernel.org>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH] xenpv: don't BUG when failing to setup NMI callback
Date: Fri, 13 Jun 2014 14:32:29 +0100 [thread overview]
Message-ID: <539AFD6D.40204@citrix.com> (raw)
In-Reply-To: <1402658788-24477-1-git-send-email-vkuznets@redhat.com>
On 13/06/14 12:26, Vitaly Kuznetsov wrote:
>
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -593,8 +593,17 @@ void xen_enable_syscall(void)
> void xen_enable_nmi(void)
> {
> #ifdef CONFIG_X86_64
> - if (register_callback(CALLBACKTYPE_nmi, (char *)nmi))
> + int ret;
> +
> + ret = register_callback(CALLBACKTYPE_nmi, (char *)nmi);
> + if (ret == -EINVAL) {
> + /* Hypervisor probably forbids us to register NMI callback,
> + that is expected when running on top of Xen-3.1 and older */
> + pr_warn("xen: failed to register NMI callback\n");
> + } else if (ret != 0) {
> + /* Other hypervisor failure */
> BUG();
I don't think we ever want to BUG() if this hypercall fails. Just print
a warning.
David
prev parent reply other threads:[~2014-06-13 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 11:26 [PATCH] xenpv: don't BUG when failing to setup NMI callback Vitaly Kuznetsov
2014-06-13 12:45 ` Konrad Rzeszutek Wilk
2014-06-13 13:14 ` Vitaly Kuznetsov
2014-06-13 13:31 ` Boris Ostrovsky
2014-06-13 13:32 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539AFD6D.40204@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=drjones@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox