* [PATCH] Suppress -Wignored-qualifiers warnings
@ 2014-06-14 9:36 Bart Van Assche
2014-06-16 7:49 ` Vincent Guittot
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2014-06-14 9:36 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Peter Zijlstra, Vincent Guittot, linux-kernel
Avoid that gcc reports the following warning when building with W=1:
warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
---
include/linux/sched.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 306f4f0..0376b05 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -872,21 +872,21 @@ enum cpu_idle_type {
#define SD_NUMA 0x4000 /* cross-node balancing */
#ifdef CONFIG_SCHED_SMT
-static inline const int cpu_smt_flags(void)
+static inline int cpu_smt_flags(void)
{
return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
}
#endif
#ifdef CONFIG_SCHED_MC
-static inline const int cpu_core_flags(void)
+static inline int cpu_core_flags(void)
{
return SD_SHARE_PKG_RESOURCES;
}
#endif
#ifdef CONFIG_NUMA
-static inline const int cpu_numa_flags(void)
+static inline int cpu_numa_flags(void)
{
return SD_NUMA;
}
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
bool cpus_share_cache(int this_cpu, int that_cpu);
typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
#define SDTL_OVERLAP 0x01
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Suppress -Wignored-qualifiers warnings
2014-06-14 9:36 [PATCH] Suppress -Wignored-qualifiers warnings Bart Van Assche
@ 2014-06-16 7:49 ` Vincent Guittot
2014-06-16 14:23 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Vincent Guittot @ 2014-06-16 7:49 UTC (permalink / raw)
To: Bart Van Assche; +Cc: Ingo Molnar, Peter Zijlstra, linux-kernel, Guenter Roeck
Hi Bart,
Guenter sent similar patch few days ago
https://lkml.org/lkml/2014/6/12/743
with additional patches for ARM and powerpc architecture
https://lkml.org/lkml/2014/6/13/399
https://lkml.org/lkml/2014/6/13/407
Vincent
On 14 June 2014 11:36, Bart Van Assche <bvanassche@acm.org> wrote:
> Avoid that gcc reports the following warning when building with W=1:
>
> warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> include/linux/sched.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 306f4f0..0376b05 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -872,21 +872,21 @@ enum cpu_idle_type {
> #define SD_NUMA 0x4000 /* cross-node balancing */
>
> #ifdef CONFIG_SCHED_SMT
> -static inline const int cpu_smt_flags(void)
> +static inline int cpu_smt_flags(void)
> {
> return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
> }
> #endif
>
> #ifdef CONFIG_SCHED_MC
> -static inline const int cpu_core_flags(void)
> +static inline int cpu_core_flags(void)
> {
> return SD_SHARE_PKG_RESOURCES;
> }
> #endif
>
> #ifdef CONFIG_NUMA
> -static inline const int cpu_numa_flags(void)
> +static inline int cpu_numa_flags(void)
> {
> return SD_NUMA;
> }
> @@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
> bool cpus_share_cache(int this_cpu, int that_cpu);
>
> typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
> -typedef const int (*sched_domain_flags_f)(void);
> +typedef int (*sched_domain_flags_f)(void);
>
> #define SDTL_OVERLAP 0x01
>
> --
> 1.8.4.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Suppress -Wignored-qualifiers warnings
2014-06-16 7:49 ` Vincent Guittot
@ 2014-06-16 14:23 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-06-16 14:23 UTC (permalink / raw)
To: Vincent Guittot, Bart Van Assche
Cc: Ingo Molnar, Peter Zijlstra, linux-kernel
On 06/16/2014 12:49 AM, Vincent Guittot wrote:
> Hi Bart,
>
> Guenter sent similar patch few days ago
> https://lkml.org/lkml/2014/6/12/743
> with additional patches for ARM and powerpc architecture
> https://lkml.org/lkml/2014/6/13/399
> https://lkml.org/lkml/2014/6/13/407
>
Still not applied, though, so maybe a few more submissions
until one of them is accepted won't hurt ;-).
Guenter
> Vincent
>
>
> On 14 June 2014 11:36, Bart Van Assche <bvanassche@acm.org> wrote:
>> Avoid that gcc reports the following warning when building with W=1:
>>
>> warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Vincent Guittot <vincent.guittot@linaro.org>
>> ---
>> include/linux/sched.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index 306f4f0..0376b05 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -872,21 +872,21 @@ enum cpu_idle_type {
>> #define SD_NUMA 0x4000 /* cross-node balancing */
>>
>> #ifdef CONFIG_SCHED_SMT
>> -static inline const int cpu_smt_flags(void)
>> +static inline int cpu_smt_flags(void)
>> {
>> return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
>> }
>> #endif
>>
>> #ifdef CONFIG_SCHED_MC
>> -static inline const int cpu_core_flags(void)
>> +static inline int cpu_core_flags(void)
>> {
>> return SD_SHARE_PKG_RESOURCES;
>> }
>> #endif
>>
>> #ifdef CONFIG_NUMA
>> -static inline const int cpu_numa_flags(void)
>> +static inline int cpu_numa_flags(void)
>> {
>> return SD_NUMA;
>> }
>> @@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
>> bool cpus_share_cache(int this_cpu, int that_cpu);
>>
>> typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
>> -typedef const int (*sched_domain_flags_f)(void);
>> +typedef int (*sched_domain_flags_f)(void);
>>
>> #define SDTL_OVERLAP 0x01
>>
>> --
>> 1.8.4.5
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-16 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-14 9:36 [PATCH] Suppress -Wignored-qualifiers warnings Bart Van Assche
2014-06-16 7:49 ` Vincent Guittot
2014-06-16 14:23 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox