From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbaFNQmV (ORCPT ); Sat, 14 Jun 2014 12:42:21 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60519 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754713AbaFNQmS (ORCPT ); Sat, 14 Jun 2014 12:42:18 -0400 Message-ID: <539C7B2F.9070800@zytor.com> Date: Sat, 14 Jun 2014 09:41:19 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" , Kees Cook CC: Pavel Machek , LKML , Randy Dunlap , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Len Brown , Wei Yongjun , "linux-doc@vger.kernel.org" , linux-pm@vger.kernel.org Subject: Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable References: <1402602419-27934-1-git-send-email-keescook@chromium.org> <1517175.iyVMqh7r2z@vostro.rjw.lan> <13135927.OjVm86GPrt@vostro.rjw.lan> In-Reply-To: <13135927.OjVm86GPrt@vostro.rjw.lan> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote: > > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL > Please don't pick numbers like this for magic numbers... *everyone else does, too.* In general, picking a random number is a good starting point; for extra bonus make sure it has at least one invalid UTF-8 sequence in it (so it cannot be confused with either ASCII or UTF-8 text.) -hpa