Re: [PATCH] Frees gate after if statement in clk-sunxi.c

Adam Baker
2014-06-14T22:12:35Z

On 14/06/14 19:11, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
> return;

There are no braces around this so the function of this code as written
is an unconditional return and the return shouldn't be indented. I
suspect, without reading the rest of the file, that that isn't what you
intended.

>
> /* allocate fixed-rate and gate clock structs */
>

Adam