From: Anil Shashikumar Belur <askb23@gmail.com>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
"<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<hpdd-discuss@lists.01.org>" <hpdd-discuss@ml01.01.org>
Subject: Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues
Date: Mon, 16 Jun 2014 11:31:04 +0530 [thread overview]
Message-ID: <539E8820.1070507@gmail.com> (raw)
In-Reply-To: <B0C4F83C-ACD6-49D0-B841-DBE1CBE3F5FC@intel.com>
> - result = +1; + result = + 1;
> This looks wrong.
> Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive nature.
> If you wanted to drop the +, that'd be fine, I guess, but in your version it looks outright wrong to me (I tested and it compiles, though).
>
> Bye,
> Oleg
Hi Oleg,
While testing the value of `result` still remains "+1", from the above
change.
I agree as suggested, its better to remove `+` and use `result = 1;`
makes it more readable.
Will redo this patch and send.
Cheers.
prev parent reply other threads:[~2014-06-16 6:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 4:28 [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues Anil Belur
2014-06-16 4:28 ` [PATCH v3 2/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 3/7] staging: lustre: lclient: lcommon_misc.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 4/7] staging: lustre: lclient: lcommon_cl.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 5/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 6/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 7/7] " Anil Belur
2014-06-16 5:05 ` Drokin, Oleg
2014-06-16 6:01 ` Anil Shashikumar Belur
2014-06-16 4:55 ` [PATCH v3 1/7] staging: lustre: lclient: glimpse.c " Drokin, Oleg
2014-06-16 6:01 ` Anil Shashikumar Belur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539E8820.1070507@gmail.com \
--to=askb23@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpdd-discuss@ml01.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox