From: Anil Shashikumar Belur <askb23@gmail.com>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
"<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<hpdd-discuss@lists.01.org>" <hpdd-discuss@ml01.01.org>
Subject: Re: [PATCH v3 7/7] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
Date: Mon, 16 Jun 2014 11:31:44 +0530 [thread overview]
Message-ID: <539E8848.3010500@gmail.com> (raw)
In-Reply-To: <6D484D74-443E-4667-9CB8-4F90EC53FB81@intel.com>
> + unsigned long cur_index;
> I wonder why move this particular declaration here?
> The only user is still in that one conditional branch anyway.
These changes are for fixing warning of line over 80 chars and indent.
maybe I should change 'unsigned long' to 'u64' keeping the line of code
in the same place.
>> /*
>> * Consistency guarantees: following possibilities exist for the
>> @@ -864,11 +865,13 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
>> * linux-2.6.18-128.1.1 miss to do that.
>> * --bug 17336 */
>> loff_t size = cl_isize_read(inode);
>> - unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
>> +
>> + cur_index = start >> PAGE_CACHE_SHIFT;
>> + loff_t check = ((size - 1) >> PAGE_CACHE_SHIFT);
> This used to produce a warning about mixing code and declarations in the past.
> Probably a bad idea to mix them anyway.
Will create a separate patch for mixed declaration error which is still
present.
next prev parent reply other threads:[~2014-06-16 6:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 4:28 [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues Anil Belur
2014-06-16 4:28 ` [PATCH v3 2/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 3/7] staging: lustre: lclient: lcommon_misc.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 4/7] staging: lustre: lclient: lcommon_cl.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 5/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 6/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 7/7] " Anil Belur
2014-06-16 5:05 ` Drokin, Oleg
2014-06-16 6:01 ` Anil Shashikumar Belur [this message]
2014-06-16 4:55 ` [PATCH v3 1/7] staging: lustre: lclient: glimpse.c " Drokin, Oleg
2014-06-16 6:01 ` Anil Shashikumar Belur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539E8848.3010500@gmail.com \
--to=askb23@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpdd-discuss@ml01.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox